From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7714BC07E9D for ; Mon, 26 Sep 2022 08:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233670AbiIZIGl (ORCPT ); Mon, 26 Sep 2022 04:06:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233581AbiIZIGO (ORCPT ); Mon, 26 Sep 2022 04:06:14 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E1471D0FC for ; Mon, 26 Sep 2022 01:03:46 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id t4so3893376wmj.5 for ; Mon, 26 Sep 2022 01:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date; bh=s1GDsk/KtoTE59u0rYU4aKY4t7QMGjP0CyyjigpbcZw=; b=sid3k+0HnjhqHkStn6TpoHVSP2SNvoyIt77MkwA/le0AROpXtk75s1MW+L+Yj66KEQ Cl10tanKlY2ZjlIPX+YwtwDOzKR714vIa7PZeCYAcTKJ83n7CbUaD85PQH8c6TFGN1rY dq3pFn9YrZIvl4zdlXLu+CjMh6uog604xE4KMeYm5xy0t+9YfUG/F2kQC5Xv8+zV4zQ9 LT0S/27aRUCze7grdKFD4ApXbXjkZle+WvYbDCdzWmfRsBMMV5SQcpIjVfR1cY8D+bO9 CD6GLsVulf8ign9872vNqVsg9HsOyHKh6J7unYy5Qs9n01QIlxY+iw0pmX16M9WM/E3i dl5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=s1GDsk/KtoTE59u0rYU4aKY4t7QMGjP0CyyjigpbcZw=; b=7k9XPCoJrDulDRO3dxfokVcu7lD4jfX2FyqVe57V4rK9WCjBhyQKtIK+5slrzSycbX 4lYW80ABcUcmK4QMJ34PDSNpt6MW4pX+ii0edrbXECyoo0scYxzLSatL9E3esZsYkaYD lSd3zaAxSGCT0hBiT2SmxnMKobfW7Vi6NKgr8+yZv/0xuPLdoDFw8uPbaDaa60q47/Tt T8we86y+GUNX3ZqeqP9AFv0zrzLU3eoAmrj0yJZAIK7ssBYNkvs+bCMTDQyX4zXnxW2c tZoVnUxlRD02gCn4GlsSJn1Ey6pKZiZ+9aGnZYXOFNE33Eph8bbT9IWBlvzokiN3qeg+ ZF3g== X-Gm-Message-State: ACrzQf0HLwjdYilgo7amf77IhBxpk3Gh3fh3glYqi3/iTUoleXud0ph9 uuOZ1DkN5YBcz9Pse+/gfQ6AyA== X-Google-Smtp-Source: AMsMyM43qYcB+JuoInA8MkWG+06M+titsDaKBTncBaaGoxvbpayvSx4rhBSH8L3N4GbbHNcI9OMGWw== X-Received: by 2002:a1c:7c03:0:b0:3b4:7647:ccd8 with SMTP id x3-20020a1c7c03000000b003b47647ccd8mr14091264wmc.10.1664179424704; Mon, 26 Sep 2022 01:03:44 -0700 (PDT) Received: from [192.168.27.65] (home.beaume.starnux.net. [82.66.176.246]) by smtp.gmail.com with ESMTPSA id w10-20020a05600c474a00b003b4ac05a8a4sm12743612wmo.27.2022.09.26.01.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 01:03:44 -0700 (PDT) Message-ID: <3c69b64e-8dcf-91e5-6863-198120c31065@linaro.org> Date: Mon, 26 Sep 2022 10:03:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/5] slimbus: qcom-ctrl: use devm_platform_ioremap_resource_byname() Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20220923155740.422411-1-krzysztof.kozlowski@linaro.org> <20220923155740.422411-3-krzysztof.kozlowski@linaro.org> Reply-To: neil.armstrong@linaro.org From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20220923155740.422411-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/09/2022 17:57, Krzysztof Kozlowski wrote: > Simplify the code with devm_platform_ioremap_resource_byname(). > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/slimbus/qcom-ctrl.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c > index bb106eab8ae2..400b7b385a44 100644 > --- a/drivers/slimbus/qcom-ctrl.c > +++ b/drivers/slimbus/qcom-ctrl.c > @@ -488,7 +488,6 @@ static int qcom_slim_probe(struct platform_device *pdev) > { > struct qcom_slim_ctrl *ctrl; > struct slim_controller *sctrl; > - struct resource *slim_mem; > int ret, ver; > > ctrl = devm_kzalloc(&pdev->dev, sizeof(*ctrl), GFP_KERNEL); > @@ -519,8 +518,7 @@ static int qcom_slim_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, ctrl); > dev_set_drvdata(ctrl->dev, ctrl); > > - slim_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl"); > - ctrl->base = devm_ioremap_resource(ctrl->dev, slim_mem); > + ctrl->base = devm_platform_ioremap_resource_byname(pdev, "ctrl"); > if (IS_ERR(ctrl->base)) > return PTR_ERR(ctrl->base); > Reviewed-by: Neil Armstrong