Re: [PATCH] accel/amdxdna: Fix Kconfig invalid configuration

[Lizhi Hou <lizhi.hou@amd.com>]

Applied to drm-misc-fixes.

On 10/9/26 08:59, Lizhi Hou wrote:
>
> On 10/8/26 18:10, Liam R. Howlett wrote:
>> The amdxdna has a soft dependency on the amd_pmf module.  It will use an
>> exported function if it is available and fall back to another function
>> if it is not enabled.
>>
>> amdxdna and amd_pmf are tridstate modules supporting both built [y] and
>> modularized [m] in the .config file.  Since the amdxdna decides to use
>> the amd_pmf if it is either a module or built in (see
>> drivers/accel/amdxdna/aie2_pci.h), then there is an issue if they are
>> not compiled either both as modules or both as built-in.
>>
>> Adding the optional dependency to Kconfig does not allow the
>> configuration from being selected.
>>
>> Fixes: f66d6cc6891e4 ("accel/amdxdna: Support sensors for column 
>> utilization")
>> Signed-off-by: Liam R. Howlett <liam@infradead.org>
>> ---
>>   drivers/accel/amdxdna/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/accel/amdxdna/Kconfig 
>> b/drivers/accel/amdxdna/Kconfig
>> index f39d7a87296cd..eddff490b4f75 100644
>> --- a/drivers/accel/amdxdna/Kconfig
>> +++ b/drivers/accel/amdxdna/Kconfig
>> @@ -6,6 +6,7 @@ config DRM_ACCEL_AMDXDNA
>>       depends on DRM_ACCEL
>>       depends on PCI && HAS_IOMEM
>>       depends on X86_64
>> +    depends on AMD_PMF || !AMD_PMF
> Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>
>>       select DRM_SCHED
>>       select DRM_GEM_SHMEM_HELPER
>>       select FW_LOADER