From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB9DC433DB for ; Thu, 25 Feb 2021 13:32:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15D8B64EF5 for ; Thu, 25 Feb 2021 13:32:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231414AbhBYNbr (ORCPT ); Thu, 25 Feb 2021 08:31:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26524 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232203AbhBYN3w (ORCPT ); Thu, 25 Feb 2021 08:29:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614259705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cX1YwP3YWDah575YgPl8iZuouPyX+en9n47H8Xk4fEg=; b=EMish+SkfXuFPKG4JTmcdie6kmG8rmGVs+L9XL2EwsVpTOkwSHMRG4ANVolWyGweBzgIfY hQsP6FqKYzjj7Xq5EaeYj6m447s2DWkD36wvGm8gVkzHvEAUj5A1MUs8fG9wPL6F2NEBgN 4XPhqUkpvNhCX/do7IuI3E/1kJx5g4Y= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131-mF8eXEY1P9Sd4zsgOmhQRA-1; Thu, 25 Feb 2021 08:28:23 -0500 X-MC-Unique: mF8eXEY1P9Sd4zsgOmhQRA-1 Received: by mail-qt1-f198.google.com with SMTP id d10so3980524qtx.8 for ; Thu, 25 Feb 2021 05:28:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=cX1YwP3YWDah575YgPl8iZuouPyX+en9n47H8Xk4fEg=; b=jXFXBW5YQF0R/OWQjok306dpp7Oe+u0JJTTc38fgrBm6SUnaqpEl6ySn8Py9EKjn0k UKDtteYxT2ileImoeH2HoRNTin9K16e3e3U089bvFV1xP8P9T4QnjKN/WWmmK/p8HK45 fzlW8KNNeWODtPEvv02pXorHQcSD3v4QauKwo4aZNQPWr3B8cFikaj1lTmQjraFXJ9Pv aji//BotENHrbbUCZjZ55hJV1B7SoqubtbnZ0RsDNCtNjKkNDcy6lK1rVnBxKPharP3U agx2WJxTcWYR2g1f/tXeqHlAk2PBFY7ErzJk/qR1qZsNP+pJypNhJtQTVnCJL2RRvs/Y oB0g== X-Gm-Message-State: AOAM5302ysgZcP2BrU+fucWu8LDpOz/eUttoGC37wxsYi5KWQisdqG2C XozJYmJGOABDFwHk6wdx+IRSDyZhA1p/C6pk25Q+WZVmeHLDtFn82tbYerIcS3sNgxgsdXRJ6Ow mrfmZY1s6HkcSSVajCZFzz8bH X-Received: by 2002:a05:622a:11:: with SMTP id x17mr2328169qtw.195.1614259702766; Thu, 25 Feb 2021 05:28:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfzYuOPUvjkC82O/gnNQNOcsg51uA3ltUcFvQWD7UhzwCAmIRLrsD1AWPny3rqz7qnxaxrzA== X-Received: by 2002:a05:622a:11:: with SMTP id x17mr2328155qtw.195.1614259702568; Thu, 25 Feb 2021 05:28:22 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id 197sm3866710qkf.33.2021.02.25.05.28.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Feb 2021 05:28:22 -0800 (PST) Subject: Re: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region To: "Gong, Richard" , "mdf@kernel.org" , "gregkh@linuxfoundation.org" , "linux-fpga@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "richard.gong@linux.intel.com" References: <1612909233-13867-1-git-send-email-richard.gong@linux.intel.com> From: Tom Rix Message-ID: <3c6d5adf-c355-f0c8-b843-5bf95f81876e@redhat.com> Date: Thu, 25 Feb 2021 05:28:20 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The first patch is a fix that is targeted for stable. Tom On 2/25/21 5:07 AM, Gong, Richard wrote: > Hi Moritz, > > Sorry for asking. > > When you have chance, can you help review the version 5 patchset submitted on 02/09/21? > > Regards, > Richard > > -----Original Message----- > From: richard.gong@linux.intel.com > Sent: Tuesday, February 9, 2021 4:20 PM > To: mdf@kernel.org; trix@redhat.com; gregkh@linuxfoundation.org; linux-fpga@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Gong, Richard > Subject: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region > > From: Richard Gong > > This is 5th submission of Intel service layer and FPGA patches, which includes the missing standalone patch in the 4th submission. > > This submission includes additional changes for Intel service layer driver to get the firmware version running at FPGA SoC device. Then FPGA manager driver, one of Intel service layer driver's client, can decide whether to handle the newly added bitstream authentication function based on the retrieved firmware version. So that we can maintain FPGA manager driver the back compatible. > > Bitstream authentication makes sure a signed bitstream has valid signatures. > > The customer sends the bitstream via FPGA framework and overlay, the firmware will authenticate the bitstream but not program the bitstream to device. If the authentication passes, the bitstream will be programmed into QSPI flash and will be expected to boot without issues. > > Extend Intel service layer, FPGA manager and region drivers to support the bitstream authentication feature. > > Richard Gong (7): > firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0 > firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag > firmware: stratix10-svc: extend SVC driver to get the firmware version > fpga: fpga-mgr: add FPGA_MGR_BITSTREAM_AUTHENTICATE flag > fpga: of-fpga-region: add authenticate-fpga-config property > dt-bindings: fpga: add authenticate-fpga-config property > fpga: stratix10-soc: extend driver for bitstream authentication > > .../devicetree/bindings/fpga/fpga-region.txt | 10 ++++ > drivers/firmware/stratix10-svc.c | 12 ++++- > drivers/fpga/of-fpga-region.c | 24 ++++++--- > drivers/fpga/stratix10-soc.c | 62 +++++++++++++++++++--- > include/linux/firmware/intel/stratix10-smc.h | 21 +++++++- > .../linux/firmware/intel/stratix10-svc-client.h | 11 +++- > include/linux/fpga/fpga-mgr.h | 3 ++ > 7 files changed, 125 insertions(+), 18 deletions(-) > > -- > 2.7.4 >