mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@linux-m68k.org>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Finn Thain <fthain@telegraphics.com.au>
Subject: Re: [PATCH v5] m68k: Replace setup_irq() by request_irq()
Date: Wed, 4 Mar 2020 11:39:41 +1000	[thread overview]
Message-ID: <3c721380-2348-dccd-8de8-5ee60a1d5240@linux-m68k.org> (raw)
In-Reply-To: <20200304013711.GA5470@afzalpc>

Hi Afzal,

On 4/3/20 11:37 am, afzal mohammed wrote:
> Hi Greg,
> 
> On Mon, Mar 02, 2020 at 11:32:53AM +1000, Greg Ungerer wrote:
> 
>> I have retested and everything works as expected, so:
>>
>>    Tested-by: Greg Ungerer <gerg@linux-m68k.org>
>>
>> I have applied this to the m68knommu git tree, for next branch.
> 
> Thanks
> 
>>>    void hw_timer_init(irq_handler_t handler)
>>>    {
>>> +	int r;
>>
>> You used 'r' here as the error return value holder.
>> But in the previous cases you used 'ret'.
>> I would have used the same name everywhere ('ret' probably being the
>> most commonly used in the kernel).
> 
> That was a circus to dodge 80 char limit, i did think about it while
> making the changes whether to do or not. If 'ret' is used request_irq()
> line had to be split to two, slightly affecting the readability and
> since 'r' was a local variable (though conventionally 'ret' or 'err'
> is used) went ahead that way. Even if 're' is used as the local
> variable, it would be 81 chars ;)
> 
> Let me know if you want to change it.

Understand. No, no need to change it.

Regards
Greg


> Regards
> afzal
> 
>>> -	setup_irq(MCF_IRQ_TIMER, &mcfslt_timer_irq);
>>> +	r = request_irq(MCF_IRQ_TIMER, mcfslt_tick, IRQF_TIMER, "timer", NULL);
>>> +	if (r) {
>>> +		pr_err("Failed to request irq %d (timer): %pe\n", MCF_IRQ_TIMER,
>>> +		       ERR_PTR(r));
>>> +	}

      reply	other threads:[~2020-03-04  1:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-29 12:56 [PATCH v3] " afzal mohammed
2020-02-29 13:25 ` afzal mohammed
2020-02-29 15:34 ` [PATCH v4] " afzal mohammed
2020-03-01  1:26   ` [PATCH v5] " afzal mohammed
2020-03-02  1:32     ` Greg Ungerer
2020-03-04  1:37       ` afzal mohammed
2020-03-04  1:39         ` Greg Ungerer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c721380-2348-dccd-8de8-5ee60a1d5240@linux-m68k.org \
    --to=gerg@linux-m68k.org \
    --cc=afzal.mohd.ma@gmail.com \
    --cc=fthain@telegraphics.com.au \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®