From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 095B531A046 for ; Wed, 26 Nov 2025 20:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764190223; cv=none; b=oE6Os4UuOs4hi/MxxCGf9HzIjQQmcoc10hGJMj2DzQ9TjIgK9puo2HGskLOoomJxmGt9+Q2IZZ4CzuYjcJjpEC5rINT9MbEAmgJTZHAqF8WF0ZgYzB78i1SDccLCDwPbZwi1VbHm+NFEgG54HsKQF9J5n/RjkSe8tEWVlAh0u2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764190223; c=relaxed/simple; bh=2hcVpa9scm0PygAHV2yhPwb8b1VqKc8achD9dLmNggM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EczXdHq0Rlkbc76CF8QOBzt7BDTsb9YfOBw95RIMie2PjlMKoJ/Dc1gx2RK8iDeZAcqUbYtmeCFAwLbVDGOFK/Fs92dKKH6fjKAaEDIqNsN+VeY1S5q1AobNinIID7eR5q7OVJYcakQuOa98f2y8rn1AREudiZQFn+8TnEJlO3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HGbDdCz7; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HGbDdCz7" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-298145fe27eso2973235ad.1 for ; Wed, 26 Nov 2025 12:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764190221; x=1764795021; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nAe7krNX/FWdcfazYkx0OEalo6w7fciX1p3CljsQHjE=; b=HGbDdCz7fMh9auA5giOKC+up0GbVoGyfdlmnW3fyA3Gxeb/N0VXaJ7h8z9oxYb4vjA g+p+ZRULTy1pYN7EVv5B4HrwMHmGfgjly+28BhEPlXXtD/KWdwSqMfXw9NDqftFHdE/T CXq15IsJHKr6bJHsZs8IrqaLSSTkzKPU2I82uX6u58ZouSHjfKSYxKn/4eti0kglBfqH 6FT1XKbMuy2JP+yi2OjHZQnX1+RHfCIkvrp4b5z+VaJHg6EoexoTIpw0JsUIvp4E42Qi xpVhXmwS0s1ou8X0njK31DhtPHOxTRa4nDS1mJWmErhGiynAQh7U5JJC+nlAPID9A7qR FYOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764190221; x=1764795021; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nAe7krNX/FWdcfazYkx0OEalo6w7fciX1p3CljsQHjE=; b=T68QxO4LCNntbAlwPRIiLytNed9cG3RxZU0w0rYjcA3AyrsJeEBdlzqNRx3XE+hVJi DLX+Tx/GaG0pm//8n3kqK7aEycent+9nsgBB4mOuSS7RARHMi0IAs0I56oNOSkXzGhTH /gtOpPgyPbsIfTa8gUrukRRgFTN2I3I4ihqOtQ7y2F+z8lbtHLFPzyOOMqCW01GQlUzd YNnkt3oWQWSyld0RsKUb3biu5wnTK9WfEkplKhbjthQk+mLR1x7UAh5CpJX5gbf7YoB8 7QQKqGlMCYj+rm7QMpPyt1A27m8QtH/RMQSmxNCJ5f7LXvI5NxDEXyX92/dLVvSu4Xkg e5Ow== X-Forwarded-Encrypted: i=1; AJvYcCX+DAkneIImu0+lGLsNlx2tTwGGbKIUyw6gsA1kfl5wmr31mzGdu9jtDAp4k2aEig3WxY50Nm1C8pQZkNw=@vger.kernel.org X-Gm-Message-State: AOJu0YyTeFJHhdIuKnGawh6ZtbNf2rOaQLcozQ6wXsoztgp5b/BeA1Ex 5/ar/KOqCPxfCNF73zfRmQeDcKSjLqCFH9sa1cqVKmZAHswb12uACYvTtc6tkxrjgg== X-Gm-Gg: ASbGnctd8Ot/WCCJh/8hJXn6nMfo9l002QL5Q0mruTQjD5x4ukfVRjBSVQipjSlLiPO IvdzwdmB4xqPs8vfVPl1wVdFxELZLXY0C7GhOxKqVwHEH9rGAAiQZFq0XhncoTATDA1VQ+hPqX7 V8I1J/fqhJ3NrBBabqudCAndkHie6I5WcTNefVSPqKuAghRdP5EMN8jBWFxEPp+/KV2ERmGhC8w lpOtH9q/jevGqDONrCvxSN6COSo6HZevYvaEbzZRVSUVNil6sX17AWgU7rVo0iPJmIkTN/PtcRU g7ZdwbtMjp52mDQctJkMYNNDcCqX/fsSYRaXJO5BMgQC2RT6Mx7s6n5XRidsSGqLMN/FDo6mp8+ lspuAELpValwsGoN4RPD888uTSt+BElnYpYikNtYiSZWbmYVmrY4+UOhqpBh6CSzUsOaEbuMo7W x01IeZawP8/+sxrsXApOJIJJy905GUnmu80hcxZJQpg96AP00yf+uqRizAvAHnqYawfKLAMh5uw s6sYOP58okMvG7+EvGmdOJY X-Google-Smtp-Source: AGHT+IFjQZz19LkV6uSbQD7V0osJzTvl1J8TedsGIZ78YPP9aLGTQiFmGEhYv2+QMQ+JGAYgRK90Dg== X-Received: by 2002:a17:902:d4ce:b0:295:596f:8507 with SMTP id d9443c01a7336-29baac9f621mr97893625ad.0.1764190220828; Wed, 26 Nov 2025 12:50:20 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:c116:b1c9:632d:a902? ([2a00:79e0:2e7c:8:c116:b1c9:632d:a902]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b12f988sm203367425ad.27.2025.11.26.12.50.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Nov 2025 12:50:20 -0800 (PST) Message-ID: <3c72e1f3-7873-4f13-a5cd-0aecc5163aab@google.com> Date: Wed, 26 Nov 2025 12:50:19 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] dt-bindings: usb: maxim,max33359: Add supply property for VBUS in OTG mode To: Heikki Krogerus Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Peter Griffin , Tudor Ambarus , Alim Akhtar , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso References: <20251123-max77759-charger-v1-0-6b2e4b8f7f54@google.com> <20251123-max77759-charger-v1-3-6b2e4b8f7f54@google.com> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Heikki, On 11/26/25 2:01 AM, Heikki Krogerus wrote: > Sun, Nov 23, 2025 at 08:35:50AM +0000, Amit Sunil Dhamne via B4 Relay kirjoitti: >> From: Amit Sunil Dhamne >> >> Add a regulator supply property for VBUS when usb is in OTG mode. > What is "OTG mode"? > > OTG is usually used to refer to the USB in device role, even though the > specification actually defines OTG device as a device capable of both > host and device roles. So the term was confusing already before. > Nevertheless, the emphasis is always on data-role, _not_ power-role. Thanks for the insight! > > Here it seems MAX33359 uses the term OTG as a synonym for "source", so > power-role? Essentially. The datasheet refers to the mode where VBUS is sourced as OTG mode. > Please don't use the term OTG unless you really have to - it's too > confusing. I know the MAX33359 datasheet uses it, but what you really > do here is regulate VBUS. So please: > > s/otg-vbus/vbus/ I will drop OTG term at least in the USB world and restrict it to the charger driver. BR, Amit > > thanks, > >> Signed-off-by: Amit Sunil Dhamne >> Reviewed-by: Badhri Jagan Sridharan >> --- >> Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml >> index 3de4dc40b791..a529f18c4918 100644 >> --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml >> +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml >> @@ -32,6 +32,9 @@ properties: >> description: >> Properties for usb c connector. >> >> + otg-vbus-supply: >> + description: Regulator to control OTG VBUS supply. >> + >> required: >> - compatible >> - reg >> @@ -53,6 +56,7 @@ examples: >> reg = <0x25>; >> interrupt-parent = <&gpa8>; >> interrupts = <2 IRQ_TYPE_LEVEL_LOW>; >> + otg-vbus-supply = <&otg_vbus_reg>; >> >> connector { >> compatible = "usb-c-connector"; >> >> -- >> 2.52.0.rc2.455.g230fcf2819-goog >>