From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD7FC4332F for ; Mon, 21 Nov 2022 14:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231867AbiKUOk3 (ORCPT ); Mon, 21 Nov 2022 09:40:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231690AbiKUOiN (ORCPT ); Mon, 21 Nov 2022 09:38:13 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42CF1AEBD8; Mon, 21 Nov 2022 06:38:12 -0800 (PST) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NG9355XMGzmVn8; Mon, 21 Nov 2022 22:37:37 +0800 (CST) Received: from dggpemm500017.china.huawei.com (7.185.36.178) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 22:38:06 +0800 Received: from [10.174.178.220] (10.174.178.220) by dggpemm500017.china.huawei.com (7.185.36.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 22:38:06 +0800 Message-ID: <3c7d52c7-6839-241e-c25e-05492bfdf115@huawei.com> Date: Mon, 21 Nov 2022 22:38:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 0/2] Fix scsi device's iodone_cnt mismatch with iorequest_cnt Content-Language: en-US To: "Martin K . Petersen" , , CC: Steffen Maier References: <20221021235638.1968832-1-haowenchao@huawei.com> From: Wenchao Hao In-Reply-To: <20221021235638.1968832-1-haowenchao@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.220] X-ClientProxiedBy: dggpeml500014.china.huawei.com (7.185.36.63) To dggpemm500017.china.huawei.com (7.185.36.178) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/10/22 7:56, Wenchao Hao wrote: > Following scenario would make scsi_device's iodone_cnt mismatch with > iorequest_cnt even if there is no request on this device any more. > > 1. request timeout happened. If we do not retry the timeouted command, > this command would be finished in scsi_finish_command() which would > not increase the iodone_cnt; if the timeouted command is retried, > another increasement for iorequest_cnt would be performed, the > command might add iorequest_cnt for multiple times but iodone_cnt > only once. Increase iodone_cnt in scsi_timeout() can handle this > scenario. > > 2. scsi_dispatch_cmd() failed, while the iorequest_cnt has already been > increased. If scsi_dispatch_cmd() failed, the request would be > requeued, then another iorequest_cnt would be added. So we should not > increase iorequest_cnt if dispatch command failed > > V2: > - Add description about why we can add iodone_cnt in scsi_timeout() > - Do not increase iorequest_cnt if dispatch command failed > > Wenchao Hao (2): > scsi: increase scsi device's iodone_cnt in scsi_timeout() > scsi: donot increase scsi_device's iorequest_cnt if dispatch failed > > drivers/scsi/scsi_error.c | 1 + > drivers/scsi/scsi_lib.c | 3 +-- > 2 files changed, 2 insertions(+), 2 deletions(-) > Hi Martin, these two count is useful for us, would like take a look?