From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758166AbdJMMC0 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Oct 2017 08:02:26 -0400
Received: from lelnx194.ext.ti.com ([198.47.27.80]:56641 "EHLO
        lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758004AbdJMMCW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Oct 2017 08:02:22 -0400
Subject: Re: [PATCH] drm/tilcdc: Remove redundant OF_DETACHED flag setting
To: Stephen Boyd <stephen.boyd@linaro.org>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>
CC: <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>
References: <20171013074755.14718-1-stephen.boyd@linaro.org>
From: Jyri Sarha <jsarha@ti.com>
Message-ID: <3c7ecc25-d41b-1f01-f78d-9d59f22a167e@ti.com>
Date: Fri, 13 Oct 2017 15:02:16 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171013074755.14718-1-stephen.boyd@linaro.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-GB
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9DC2UPo031673


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 10/13/17 10:47, Stephen Boyd wrote:
> of_fdt_unflatten_tree() already sets the flag on this node to
> OF_DETACHED, because of_fdt_unflatten_tree() calls
> __unflatten_device_tree() with the detached bool set to true.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> index 623a9140493c..482299a6f3b0 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> @@ -163,7 +163,6 @@ static struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft)
>  		return NULL;
>  	}
>  
> -	of_node_set_flag(overlay, OF_DETACHED);
>  	ret = of_resolve_phandles(overlay);
>  	if (ret) {
>  		pr_err("%s: Failed to resolve phandles: %d\n", __func__, ret);
> 

Acked-by: Jyri Sarha <jsarha@gmail.com>

I'll pick this up for my next pull request.