From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D00EB64DA for ; Sat, 22 Jul 2023 09:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbjGVJkt (ORCPT ); Sat, 22 Jul 2023 05:40:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbjGVJkp (ORCPT ); Sat, 22 Jul 2023 05:40:45 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C572CFE for ; Sat, 22 Jul 2023 02:40:43 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3144bf65ce9so2084324f8f.3 for ; Sat, 22 Jul 2023 02:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690018842; x=1690623642; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xVvfPKzKcVpH1QI0csRcWXxVggvuQ6kRzOg+ZisbYTE=; b=Q7CO1h4q8n2TRKOtekDzx5eLhCfgNlPO28K68CQZU3y8GiG6UNolrcefO64AH5kG7E afp52OcpYW7EXp1ut+7fV5maT0O9zlJHqYfXTt+tkHTa0mN3oqbSD11WnOCZUKtDgZU6 QO7/r37xHHOMkAiXGjVw4Qd8PY6eD0iBlp0dGACwL4nlxvJAXSmCtVYgWQjsEtNJ+JWn cS/Cva+Zm7QvdLFITiyCB/GCJLxPbd4WTapTR23vw5BstGx8XRlm1bozaBB3czz+gjJk Lu9BKEdoG8HZkUBE9lxhQNduRRIWs6CvE/Too0X0xkZpYD0nHli5TSrJ5CGOuqF1WiDy QfsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690018842; x=1690623642; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xVvfPKzKcVpH1QI0csRcWXxVggvuQ6kRzOg+ZisbYTE=; b=SYVNKqNQw+ytPnhgR6KNr1TLwl/66rfDBnnVAO7TxX0q3MVNYlqJhWEn/M1s1DULvd QhXQ10X83ar5GTwhctEolnjSvtMu5GYRQHuFBm87C8kuMHLXK2J0cU6ospQrirjKgQtb szIs9SAZoqFJSIHjDeahE23s2SE3tDubzeK/tqCCmBNDZB0h4ncWEEbm7LiemyPavXsJ iZXpmqoN9/uyNdFkpphIvXSCOWn280whbdl3hRyy9zI7fYFCxZiw3b6/qDYoh4mI5VQZ /0ozvIePTRt2oFqBS8hZnfz/l+K5t2v5Cy5uslPhsULSdT0tFIXicHrA5kiW7IKyVHds d75w== X-Gm-Message-State: ABy/qLbcrYZi2d8YelHuDAEI/swkSrep0125LrxV51/b4tE3TZsZuK/Y hHHEvEbb91cjdw9y60As/gtmAA== X-Google-Smtp-Source: APBJJlHI5yXhsp3L7DFOZwhHFHT2Jtn8D1u4C1uU1SHS2dWNL8s1Jo6yY1vVSWkoZ2N2CtQtKB04Cw== X-Received: by 2002:adf:e852:0:b0:313:f1a4:4112 with SMTP id d18-20020adfe852000000b00313f1a44112mr2637672wrn.33.1690018842189; Sat, 22 Jul 2023 02:40:42 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id o26-20020a5d58da000000b0030ae499da59sm6436715wrf.111.2023.07.22.02.40.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jul 2023 02:40:41 -0700 (PDT) Message-ID: <3c83f4af-3512-2def-0532-1d8c34ee6fcb@linaro.org> Date: Sat, 22 Jul 2023 11:40:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/7] dt-bindings: interconnect: qcom: Fix and separate out QCS404 Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo Cc: Marijn Suijten , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230721-topic-icc_bindings-v1-0-93e2bc728fb7@linaro.org> <20230721-topic-icc_bindings-v1-4-93e2bc728fb7@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230721-topic-icc_bindings-v1-4-93e2bc728fb7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/2023 15:54, Konrad Dybcio wrote: > Separate out QCS404 icc bindings from the common file and fix the > clocks description by removing the wrong internal RPM bus clock > representation that we've been carrying for years. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/interconnect/qcom,qcs404.yaml | 52 ++++++++++++++++++++++ > .../devicetree/bindings/interconnect/qcom,rpm.yaml | 6 --- > 2 files changed, 52 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml > new file mode 100644 > index 000000000000..aff2daa55802 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interconnect/qcom,qcs404.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm QCS404 Network-On-Chip interconnect > + > +maintainers: > + - Konrad Dybcio > + > +description: | > + The Qualcomm QCS404 interconnect providers support adjusting the > + bandwidth requirements between the various NoC fabrics. > + > +allOf: > + - $ref: qcom,rpm-common.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,qcs404-bimc > + - qcom,qcs404-pcnoc > + - qcom,qcs404-snoc I am not sure it is reasonable to keep such short bindings each in its own file. Maybe 8916 and qcs404 should be left in common file? > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + > + snoc: interconnect@580000 { > + compatible = "qcom,qcs404-snoc"; > + reg = <0x00580000 0x23080>; > + #interconnect-cells = <1>; > + }; > + > + pcnoc: interconnect@500000 { > + compatible = "qcom,qcs404-pcnoc"; > + reg = <0x00500000 0x15080>; > + #interconnect-cells = <1>; > + }; > + > + bimc: interconnect@400000 { > + compatible = "qcom,qcs404-bimc"; > + reg = <0x00400000 0x80000>; > + #interconnect-cells = <1>; > + }; Keep only one example. Best regards, Krzysztof