mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wangyufen <wangyufen@huawei.com>
To: <gregkh@linuxfoundation.org>, <linus.walleij@linaro.org>,
	<mailhol.vincent@wanadoo.fr>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()
Date: Tue, 29 Nov 2022 14:24:44 +0800	[thread overview]
Message-ID: <3c8b9e41-dabb-f6f6-04e7-778c91a6b432@huawei.com> (raw)
In-Reply-To: <1669704115-40011-1-git-send-email-wangyufen@huawei.com>

Please ignore.

Thanks.

在 2022/11/29 14:41, Wang Yufen 写道:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
> 
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
>   drivers/usb/host/fhci-hcd.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..ca4b311 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
>   					NULL, i, GPIOD_OUT_LOW);
>   
>   		if (IS_ERR(fhci->gpiods[i])) {
> -			dev_err(dev, "incorrect GPIO%d: %ld\n",
> -				i, PTR_ERR(fhci->gpiods[i]));
> +			ret = PTR_ERR(fhci->gpiods[i])
> +			dev_err(dev, "incorrect GPIO%d: %d\n",
> +				i, ret);
>   			goto err_gpios;
>   		}
>   		if (!fhci->gpiods[i]) {

  reply	other threads:[~2022-11-29  6:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29  6:41 Wang Yufen
2022-11-29  6:24 ` wangyufen [this message]
2022-12-03  9:52 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c8b9e41-dabb-f6f6-04e7-778c91a6b432@huawei.com \
    --to=wangyufen@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®