From: Dev Jain <dev.jain@arm.com>
To: Zenghui Yu <zenghui.yu@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, vbabka@kernel.org, surenb@google.com,
mhocko@suse.com, brendan.jackman@linux.dev, hannes@cmpxchg.org,
ziy@nvidia.com
Subject: Re: [PATCH] mm/page_alloc: remove unneeded forward declaration of __free_pages_ok()
Date: Fri, 23 Oct 2026 17:59:36 +0530 [thread overview]
Message-ID: <3c8d974f-55ff-455a-8676-d1ee823166e4@arm.com> (raw)
In-Reply-To: <20261022124504.75642-1-zenghui.yu@linux.dev>
On 22/10/26 6:15 pm, Zenghui Yu wrote:
> From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
>
> All remaining callers of __free_pages_ok() appear after its definition, so
> the forward declaration near the top of mm/page_alloc.c is no longer
> needed. Remove it.
>
> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
> ---
Reviewed-by: Dev Jain <dev.jain@arm.com>
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0396c50b96f0..6db90e0aa929 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -216,8 +216,6 @@ gfp_t gfp_allowed_mask __read_mostly = GFP_BOOT_MASK;
> unsigned int pageblock_order __read_mostly;
> #endif
>
> -static void __free_pages_ok(struct page *page, unsigned int order,
> - fpi_t fpi_flags);
> static void reserve_highatomic_pageblock(struct page *page, int order,
> struct zone *zone);
>
prev parent reply other threads:[~2026-10-23 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 12:45 Zenghui Yu
2026-10-22 14:12 ` Zi Yan
2026-10-22 16:43 ` Johannes Weiner
2026-10-23 11:11 ` Anshuman Khandual
2026-10-23 12:29 ` Dev Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c8d974f-55ff-455a-8676-d1ee823166e4@arm.com \
--to=dev.jain@arm.com \
--cc=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=zenghui.yu@linux.dev \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®