From: Dave Hansen <dave.hansen@intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Bin Yang <bin.yang@intel.com>, Mark Gross <mark.gross@intel.com>
Subject: [PATCH 0/8] x86/mm/cpa: Further optimizations
Date: Fri, 21 Sep 2018 15:50:23 -0700 [thread overview]
Message-ID: <3c91a770-566c-5ac0-b899-18bc4e339e4e@intel.com> (raw)
In-Reply-To: <20180919085016.164552924@infradead.org>
On 09/19/2018 01:50 AM, Peter Zijlstra wrote:
> Dave, can you have a wee look at the Atom errata thing; this does grow the
> amount of code between the page-table update and the TLB flush a bit, but all
> that PTI crud we did a while back already made it a non-trivial amount of code.
Oh, were you worried that the act of sending the IPIs widens the window
vs. just doing the local flush? We definitely do the
smp_call_function() dance *before* we do the local TLB invalidation in
in on_each_cpu().
But, the existing flush was not a "true" fix anyway. It just tended to
work around things.
If the issue pops back up, I'd prefer that we just do:
__flush_tlb_all();
flush_tlb_all();
Preferably with an actual model/family check for the "AAH41" workaround.
The real value of what you did was moving the flush_tlb_all() closer,
and that remains either way.
next prev parent reply other threads:[~2018-09-21 22:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 8:50 Peter Zijlstra
2018-09-19 8:50 ` [PATCH 1/8] x86/mm/cpa: Use flush_tlb_all() Peter Zijlstra
2018-09-19 9:15 ` Peter Zijlstra
2018-09-19 10:08 ` Thomas Gleixner
2018-09-27 18:51 ` [tip:x86/mm] " tip-bot for Peter Zijlstra
2018-09-19 8:50 ` [PATCH 2/8] x86/mm/cpa: Move flush_tlb_all() Peter Zijlstra
2018-09-21 21:34 ` Dave Hansen
2018-09-22 10:37 ` Peter Zijlstra
2018-09-24 16:11 ` Dave Hansen
2018-09-27 18:52 ` [tip:x86/mm] " tip-bot for Peter Zijlstra
2018-09-19 8:50 ` [PATCH 3/8] x86/mm/cpa: Unconditionally avoid WBINDV when we can Peter Zijlstra
2018-09-27 18:53 ` [tip:x86/mm] " tip-bot for Peter Zijlstra
2018-09-19 8:50 ` [PATCH 4/8] x86/mm/cpa: Use flush_tlb_kernel_range() Peter Zijlstra
2018-09-27 18:53 ` [tip:x86/mm] " tip-bot for Peter Zijlstra
2018-09-19 8:50 ` [PATCH 5/8] x86/mm/cpa: Move CLFLUSH test into cpa_flush_range() Peter Zijlstra
2018-09-27 18:54 ` [tip:x86/mm] " tip-bot for Peter Zijlstra
2018-09-19 8:50 ` [PATCH 6/8] x86/mm/cpa: Move CLFLUSH test into cpa_flush_array() Peter Zijlstra
2018-09-27 18:54 ` [tip:x86/mm] " tip-bot for Peter Zijlstra
2018-09-19 8:50 ` [PATCH 7/8] x86/mm/cpa: Factor common code between cpa_flush_*() Peter Zijlstra
2018-09-27 18:55 ` [tip:x86/mm] " tip-bot for Peter Zijlstra
2018-09-19 8:50 ` [PATCH 8/8] x86/mm/cpa: Optimize __cpa_flush_range() Peter Zijlstra
2018-09-27 18:55 ` [tip:x86/mm] " tip-bot for Peter Zijlstra
2018-09-21 22:50 ` Dave Hansen [this message]
2018-09-21 22:50 ` [PATCH 0/8] x86/mm/cpa: Further optimizations Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c91a770-566c-5ac0-b899-18bc4e339e4e@intel.com \
--to=dave.hansen@intel.com \
--cc=bin.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome