From: "Arnd Bergmann" <arnd@arndb.de>
To: "Marc Zyngier" <maz@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: apple: Fix dependency on 16kB pages
Date: Mon, 01 Apr 2024 14:23:27 +0200 [thread overview]
Message-ID: <3c9523b7-9bba-4fe2-97a1-893e8505e054@app.fastmail.com> (raw)
In-Reply-To: <20240401121933.600977-1-maz@kernel.org>
On Mon, Apr 1, 2024, at 14:19, Marc Zyngier wrote:
> While d3e5bab923d3 consolidated the various definitions for page sizes,
> it ended up breaking the Apple PCIe driver, which still depends on
> ARM64_PAGE_SHIFT. Switch over to HAVE_PAGE_SIZE_16KB to make the driver
> selectable again.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Fixes: d3e5bab923d3 ("arch: simplify architecture specific page size
> configuration")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
The dependency only exists in the asahi kernel with commit
db5709e83c11 ("PCI: apple: Add depends on ARM64_PAGE_SHIFT = 14")
and is not present upstream.
Arnd
next prev parent reply other threads:[~2024-04-01 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 12:19 Marc Zyngier
2024-04-01 12:23 ` Arnd Bergmann [this message]
2024-04-01 12:29 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c9523b7-9bba-4fe2-97a1-893e8505e054@app.fastmail.com \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®