From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756506AbcIMIp1 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Sep 2016 04:45:27 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:4823 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755855AbcIMIpZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Sep 2016 04:45:25 -0400
X-PGP-Universal: processed;
        by hqnvupgp08.nvidia.com on Tue, 13 Sep 2016 01:40:10 -0700
Subject: Re: [PATCH] dmaengine: squash lines for immediate return
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
        <dmaengine@vger.kernel.org>
References: <1473708054-30989-1-git-send-email-yamada.masahiro@socionext.com>
CC: Linus Walleij <linus.walleij@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Peter Griffin <peter.griffin@linaro.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Vinod Koul <vinod.koul@intel.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "Alexandre Courbot" <gnurou@gmail.com>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <3c992f57-8397-d46a-59be-55dd9457e890@nvidia.com>
Date: Tue, 13 Sep 2016 09:45:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1473708054-30989-1-git-send-email-yamada.masahiro@socionext.com>
X-Originating-IP: [10.21.132.115]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com
 (10.26.138.13)
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/09/16 20:20, Masahiro Yamada wrote:
> Remove unneeded variables and assignments.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/dma/cppi41.c          | 30 +++++-------------------------
>  drivers/dma/imx-sdma.c        | 15 ++++-----------
>  drivers/dma/ppc4xx/adma.c     | 15 ++++++---------
>  drivers/dma/tegra20-apb-dma.c |  4 +---
>  4 files changed, 16 insertions(+), 48 deletions(-)

...

> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 6ab9eb9..89795a2 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -337,9 +337,7 @@ static struct tegra_dma_sg_req *tegra_dma_sg_req_get(
>  	}
>  	spin_unlock_irqrestore(&tdc->lock, flags);
>  
> -	sg_req = kzalloc(sizeof(struct tegra_dma_sg_req), GFP_NOWAIT);
> -
> -	return sg_req;
> +	return kzalloc(sizeof(struct tegra_dma_sg_req), GFP_NOWAIT);
>  }
>  
>  static int tegra_dma_slave_config(struct dma_chan *dc,

For the Tegra bit ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic