From: John Linn <John.Linn@xilinx.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <catalin.marinas@arm.com>,
<glikely@secretlab.ca>
Subject: RE: [PATCH V2 1/4] ARM: Xilinx: Adding Xilinx board support
Date: Mon, 14 Feb 2011 07:41:47 -0700 [thread overview]
Message-ID: <3c99c5b6-61cd-4049-9461-04c60fceaa7b@VA3EHSMHS028.ehs.local> (raw)
In-Reply-To: <20110212121320.GH15616@n2100.arm.linux.org.uk>
> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk]
> Sent: Saturday, February 12, 2011 5:13 AM
> To: John Linn
> Cc: linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; catalin.marinas@arm.com;
> glikely@secretlab.ca
> Subject: Re: [PATCH V2 1/4] ARM: Xilinx: Adding Xilinx board support
>
> On Wed, Feb 09, 2011 at 10:00:42AM -0700, John Linn wrote:
> > +/* arch/arm/mach-xilinx/board_ep107.c
> > + *
> > + * This file contains code specific to the Xilinx EP107 board.
> > + *
> > + * Copyright (C) 2011 Xilinx
> > + *
> > + * based on /arch/arm/mach-realview/core.c
> > + *
> > + * Copyright (C) 1999 - 2003 ARM Limited
> > + * Copyright (C) 2000 Deep Blue Solutions Ltd
> > + *
> > + * This program is free software; you can redistribute it and/or
modify
> > + * it under the terms of the GNU General Public License as
published by
> > + * the Free Software Foundation; either version 2 of the License,
or
> > + * (at your option) any later version.
> > + *
> > + * You should have received a copy of the GNU General Public
License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA
>
> You probably don't want to include this paragraph - their address
keeps
> changing, so will require files to be constantly updated.
Makes sense. Easy to fix.
>
> > + */
> > +
> > +#include <linux/platform_device.h>
> > +#include <asm/mach-types.h>
> > +#include <asm/mach/arch.h>
> > +#include <mach/xilinx_soc.h>
> > +#include <mach/irqs.h>
> > +#include <linux/clkdev.h>
>
> Please group linux/ includes together, then asm/ includes, lastly
mach/
> includes.
>
> > @@ -0,0 +1,113 @@
> > +/* arch/arm/mach-xilinx/common.c
> ...
> > +/**
> > + * system_init - System specific initialization, intended to be
called from
> > + * board specific initialization.
> > + *
> > + **/
> > +void __init system_init(void)
>
> Is there a better name for this - maybe prefixing it with xilinx_ ?
Sure, that's easy.
>
> > +{
> > +#ifdef CONFIG_CACHE_L2X0
> > + /*
> > + * 64KB way size, 8-way associativity, parity disabled
> > + */
> > + l2x0_init(PL310_L2CC_BASE, 0x02060000, 0xF0F0FFFF);
> > +#endif
> > +}
> > +
> > +/**
> > + * irq_init - Interrupt controller initialization for the GIC.
> > + *
> > + **/
> > +void __init irq_init(void)
>
> Ditto.
Same thing, easy.
>
> > +/**
> > + * map_io - Create memory mappings needed for early I/O.
> > + *
> > + **/
> > +void __init map_io(void)
>
> Ditto.
Yep.
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
next prev parent reply other threads:[~2011-02-14 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1297270845-18802-1-git-send-email-john.linn@xilinx.com>
2011-02-09 17:00 ` John Linn
2011-02-12 12:13 ` Russell King - ARM Linux
2011-02-14 14:41 ` John Linn [this message]
[not found] ` <1297270845-18802-2-git-send-email-john.linn@xilinx.com>
2011-02-09 17:00 ` [PATCH V2 2/4] ARM: Xilinx: Adding timer support to the platform John Linn
[not found] ` <1297270845-18802-3-git-send-email-john.linn@xilinx.com>
2011-02-09 17:00 ` [PATCH V2 3/4] ARM: Xilinx: base header files and assembly macros John Linn
2011-02-12 12:16 ` Russell King - ARM Linux
2011-02-14 14:42 ` [PATCH V2 3/4] ARM: Xilinx: base header files and assemblymacros John Linn
[not found] ` <1297270845-18802-4-git-send-email-john.linn@xilinx.com>
2011-02-09 17:00 ` [PATCH V2 4/4] ARM: Xilinx: Adding Xilinx platform infrastructure support John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c99c5b6-61cd-4049-9461-04c60fceaa7b@VA3EHSMHS028.ehs.local \
--to=john.linn@xilinx.com \
--cc=catalin.marinas@arm.com \
--cc=glikely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®