From: Nanyong Sun <sunnanyong@huawei.com>
To: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>
Cc: <palmerdabbelt@google.com>, <wangkefeng.wang@huawei.com>,
<anup@brainfault.org>, <alex@ghiti.fr>, <jszhang@kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next 0/2] riscv/mm: Enable THP migration
Date: Thu, 30 Dec 2021 14:45:57 +0800 [thread overview]
Message-ID: <3c9ba160-74b2-a933-e8e5-9fd5359dc2cc@huawei.com> (raw)
In-Reply-To: <20211123140638.3852400-1-sunnanyong@huawei.com>
Hi Palmer,
This patchset has been sent for one month ago, I was wondering if you could
have a review and give a feedback please, thanks.
On 2021/11/23 22:06, Nanyong Sun wrote:
> This series enables THP migration on riscv via ARCH_ENABLE_THP_MIGRATION.
> But first this adjusts PAGE_PROT_NONE to satisfy generic memory semantics
> like the behavior of pmd_present() and pmd_trans_huge() when in
> THP splitting or migration.
>
> This feature can reduce the time of THP migration by not splits THP
> before migration and can guarantee the pages after migration are still
> contiguous.[1]
>
> I have tested the below test case on qemu based on riscv after
> enabling this feature, the throughput of THP migration gains 13x
> performance improvement:
> https://github.com/x-y-z/thp-migration-bench
>
> I also have tested and passed the test cases under
> tools/testing/selftests/vm.
>
> [1]: https://lwn.net/Articles/723764/
>
> Nanyong Sun (2):
> riscv/mm: Adjust PAGE_PROT_NONE to comply with THP semantics
> riscv/mm: Enable THP migration
>
> arch/riscv/Kconfig | 1 +
> arch/riscv/include/asm/pgtable-bits.h | 2 +-
> arch/riscv/include/asm/pgtable.h | 16 +++++++++++-----
> 3 files changed, 13 insertions(+), 6 deletions(-)
>
next prev parent reply other threads:[~2021-12-30 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 14:06 Nanyong Sun
2021-11-23 14:06 ` [PATCH -next 1/2] riscv/mm: Adjust PAGE_PROT_NONE to comply with THP semantics Nanyong Sun
2021-11-23 14:06 ` [PATCH -next 2/2] riscv/mm: Enable THP migration Nanyong Sun
2021-12-30 6:45 ` Nanyong Sun [this message]
2022-01-09 17:49 ` [PATCH -next 0/2] " Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c9ba160-74b2-a933-e8e5-9fd5359dc2cc@huawei.com \
--to=sunnanyong@huawei.com \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®