From: Jens Axboe <axboe@kernel.dk>
To: Alden Tondettar <alden.tondettar@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>,
linux-efi@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] partitions/efi: Fix integer overflow in GPT size calculation
Date: Tue, 17 Jan 2017 08:03:14 -0800 [thread overview]
Message-ID: <3c9bc8f7-7fb8-64d7-f195-7aadfd2cbb14@kernel.dk> (raw)
In-Reply-To: <1484519516-18295-1-git-send-email-alden.tondettar@gmail.com>
On 01/15/2017 02:31 PM, Alden Tondettar wrote:
> If a GUID Partition Table claims to have more than 2**25 entries, the
> calculation of the partition table size in alloc_read_gpt_entries() will
> overflow a 32-bit integer and not enough space will be allocated for the
> table.
>
> Nothing seems to get written out of bounds, but later efi_partition() will
> read up to 32768 bytes from a 128 byte buffer, possibly OOPSing or exposing
> information to /proc/partitions and uevents.
>
> The problem exists on both 64-bit and 32-bit platforms.
>
> Fix the overflow and also print a meaningful debug message if the table
> size is too large.
Applied for 4.11, thanks.
--
Jens Axboe
prev parent reply other threads:[~2017-01-17 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 22:31 Alden Tondettar
2017-01-17 16:00 ` Ard Biesheuvel
2017-01-17 16:03 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c9bc8f7-7fb8-64d7-f195-7aadfd2cbb14@kernel.dk \
--to=axboe@kernel.dk \
--cc=alden.tondettar@gmail.com \
--cc=dave@stgolabs.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®