mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Yehyeong Lee <yhlee@isslab.korea.ac.kr>, linux-rdma@vger.kernel.org
Cc: jgg@ziepe.ca, leon@kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] RDMA/srp: fix use-after-free of a request in srp_destroy_qp()
Date: Tue, 18 Aug 2026 09:26:42 -0700	[thread overview]
Message-ID: <3ca5809e-96be-4073-8596-4ab53d72d6b9@acm.org> (raw)
In-Reply-To: <20260818035229.505098-2-yhlee@isslab.korea.ac.kr>

On 8/17/26 8:52 PM, Yehyeong Lee wrote:
> -static int srp_inv_rkey(struct srp_request *req, struct srp_rdma_ch *ch,
> -		u32 rkey)
> +static int srp_inv_rkey(struct srp_rdma_ch *ch, u32 rkey)
>   {
>   	struct ib_send_wr wr = {
>   		.opcode		    = IB_WR_LOCAL_INV,
> @@ -1170,8 +1173,7 @@ static int srp_inv_rkey(struct srp_request *req, struct srp_rdma_ch *ch,
>   		.ex.invalidate_rkey = rkey,
>   	};
>   
> -	wr.wr_cqe = &req->reg_cqe;
> -	req->reg_cqe.done = srp_inv_rkey_err_done;
> +	wr.wr_cqe = &ch->inv_cqe;
>   	return ib_post_send(ch->qp, &wr, NULL);
>   }

This patch introduces a race condition because it associates a single
CQE data structure with multiple concurrently submitted work requests.
Please drop this patch.

Thanks,

Bart.

  reply	other threads:[~2026-08-18 16:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  3:52 [PATCH v2 0/2] " Yehyeong Lee
2026-08-18  3:52 ` [PATCH v2 1/2] " Yehyeong Lee
2026-08-18 16:26   ` Bart Van Assche [this message]
2026-08-19  2:10     ` Yehyeong Lee
2026-08-18  3:52 ` [PATCH v2 2/2] RDMA/srp: Fix srp_remove_target() Yehyeong Lee
2026-09-02 12:59 ` (subset) [PATCH v2 0/2] RDMA/srp: fix use-after-free of a request in srp_destroy_qp() Leon Romanovsky
2026-09-04 17:51   ` Bart Van Assche
2026-08-19  1:48 [PATCH v2 1/2] " Yehyeong Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ca5809e-96be-4073-8596-4ab53d72d6b9@acm.org \
    --to=bvanassche@acm.org \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=yhlee@isslab.korea.ac.kr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®