mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ad4080: configure backend data size
Date: Tue, 23 Jun 2026 18:07:39 -0500	[thread overview]
Message-ID: <3caf5748-0da2-4f11-a0ff-d3dd5fdf339f@baylibre.com> (raw)
In-Reply-To: <20260623090717.3296-3-antoniu.miclaus@analog.com>

On 6/23/26 4:07 AM, Antoniu Miclaus wrote:
> The AXI backend needs to know the ADC word width in order to pack the
> sample data correctly on the bus. During channel setup, program the
> backend packet format via iio_backend_data_size_set() using the channel
> resolution, so the data is transferred according to the device's
> realbits.
> 

Do we need a Fixes: tag?

> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>  drivers/iio/adc/ad4080.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
> index 8d2953341b15..8feb0c7f7fcb 100644
> --- a/drivers/iio/adc/ad4080.c
> +++ b/drivers/iio/adc/ad4080.c
> @@ -698,6 +698,11 @@ static int ad4080_setup_channel(struct ad4080_state *st, unsigned int ch)
>  	if (ret)
>  		return ret;
>  
> +	ret = iio_backend_data_size_set(st->back[ch],
> +					st->info->channels[0].scan_type.realbits);
> +	if (ret)
> +		return ret;
> +
>  	if (!st->lvds_cnv_en)
>  		return 0;
>  


  reply	other threads:[~2026-06-23 23:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  9:07 [PATCH 0/2] iio: adc: ad4080: add backend data size configuration Antoniu Miclaus
2026-06-23  9:07 ` [PATCH 1/2] iio: adc: adi-axi-adc: add data size support for AD408X backend Antoniu Miclaus
2026-06-23  9:07 ` [PATCH 2/2] iio: adc: ad4080: configure backend data size Antoniu Miclaus
2026-06-23 23:07   ` David Lechner [this message]
2026-07-12  0:48     ` Jonathan Cameron
2026-07-13  8:07       ` Miclaus, Antoniu
2026-06-23 23:09 ` [PATCH 0/2] iio: adc: ad4080: add backend data size configuration David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3caf5748-0da2-4f11-a0ff-d3dd5fdf339f@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox