From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755353AbdERP6t (ORCPT ); Thu, 18 May 2017 11:58:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47414 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754790AbdERP6o (ORCPT ); Thu, 18 May 2017 11:58:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 12DF4C04B93A Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=longman@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 12DF4C04B93A Subject: Re: [RFC PATCH v2 10/17] cgroup: Make debug cgroup support v2 and thread mode To: Tejun Heo References: <1494855256-12558-1-git-send-email-longman@redhat.com> <1494855256-12558-11-git-send-email-longman@redhat.com> <20170517214338.GG942@htj.duckdns.org> Cc: Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de From: Waiman Long Organization: Red Hat Message-ID: <3cb18ea6-fcc1-af92-3926-d65ae0a30b97@redhat.com> Date: Thu, 18 May 2017 11:58:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170517214338.GG942@htj.duckdns.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 18 May 2017 15:58:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2017 05:43 PM, Tejun Heo wrote: > Hello, > > On Mon, May 15, 2017 at 09:34:09AM -0400, Waiman Long wrote: >> Besides supporting cgroup v2 and thread mode, the following changes >> are also made: >> 1) current_* cgroup files now resides only at the root as we don't >> need duplicated files of the same function all over the cgroup >> hierarchy. >> 2) The cgroup_css_links_read() function is modified to report >> the number of tasks that are skipped because of overflow. >> 3) The relationship between proc_cset and threaded_csets are displayed. >> 4) The number of extra unaccounted references are displayed. >> 5) The status of being a thread root or threaded cgroup is displayed. >> 6) The current_css_set_read() function now prints out the addresses of >> the css'es associated with the current css_set. >> 7) A new cgroup_subsys_states file is added to display the css objects >> associated with a cgroup. >> 8) A new cgroup_masks file is added to display the various controller >> bit masks in the cgroup. >> >> Signed-off-by: Waiman Long > As noted before, please make it clear that this is a debug feature and > not expected to be stable. Also, I don't see why this and the > previous two patches are in this series. Can you please split these > out to a separate patchset? > > Thanks. > Sure. I can separate out the debug code into a separate patchset. It is just easier to manage as a single patchset than 2 separate ones. Regards, Longman