From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794493372; b=FQb8eZm2VnIui+ukzHbTzupQ1YnDfYDMaOQzUbFgPcZlhU6ZaMVZXoo116Fpcrbw/VW9 jrsHCOrXU7kXQ7yj6GBI1RD2DLsqksY6NiOiGx2IrkTPj1HtxZjW/LOGs3vVWshZE2HTC MAc7jvFfKyFEXUalLTUid0Puz+vmcxZRsD3ngPUxpQJMd/Jm4R2TB5t1qwegDku64fao3 jz1/BTecTDsMI9GZsVXk7jZTHZL7QFaUYAWhkRFUOSY9hIs0yQ6YYd8vmSCGRLXN2mJ87 HxRDTXV/fSNBGvNbr9mM7+L4uugXFp2YRQHGDR/XhAZRAmCI8jh/xX255/RV4kyqJvg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794493372; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:From:To:Cc:References: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-Spam-Info:X-Proofpoint-GUID:X-Authority-Analysis: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=+eMaexRE5YK9LKV2U20lRzNlg/Uqk666DN6/XsuIY9E=; b=mAguLWyM7Uu4pE3aSGOorjSqffxYqfi2tkjzf+NlSF1NtME0bpHY0FbVjR1vyVbRCwTn 0Wc6lnNNKu8M4PiUa1NyNA+IQHEHYbmYsFle/XH3ldXeGZuge9MeIRtDNpUo/4IxBFkvA 1xjFDncXuiQ8IJ06oHidrX6Qj5EoYKQ3HFsJsa8wufa1LBtZ/vgPqHYz9os0jby7OjSac 5zyO2qD6gCC7GfQjFxsWwUZ4a5Bvc6e0C6bkZuaJRJd4XFzvYUqgrNiTCFNPjAkxm0YTp pqsBhWPgD5m7ltCsi0pPN714EjpeQrq+IWd94iNGZD06BZLGU6Rc8UE6MtwCSE1s5DA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=QRn4WhY8; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b="Ii4ssk/m"; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A325606A898 for ; Thu, 12 Nov 2026 14:22:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1A325606A898 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=QRn4WhY8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Ii4ssk/m Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AC91Ipm4149283 for ; Thu, 12 Nov 2026 14:22:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +eMaexRE5YK9LKV2U20lRzNlg/Uqk666DN6/XsuIY9E=; b=QRn4WhY8RG9Z8KVP f3dKHXO4obz0OeZ36CntkiZecVhpROOHa15oszqHYOWx2HSCmTzeCeo1DryB7tHh U5RS4LsF8L4jrx7PPUsqmJiAcIqN1py+35b47WlIhjdNCN6U/5W4P6BDls4qnFnP QbUranhaa59lowsrk7XGcwU1wAvzAetzUhYzXnpJERt0HvFh1MVUaC7MidceQFXA DSbVmCkaEE1bbFDiqtn/UeG3rHWE4CPruCNQe053ryQ+egPrPlnnIvpZ3jimM9zw G1AuX3s/11GkkbBzAroRpouZbauyvCTsZla07Dr6aAdLO6EYafbS5Lir9GhSvxrl GBkO1Q== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hvxc63sfk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Nov 2026 14:22:50 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8b60129a46eso5738299b3a.1 for ; Thu, 12 Nov 2026 06:22:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794493370; x=1795098170; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+eMaexRE5YK9LKV2U20lRzNlg/Uqk666DN6/XsuIY9E=; b=Ii4ssk/mhdJWrdV93RTlZvIBWCPjwUnnu1DxEIAL4jSQUiZN0RguCShe1UxWY6eF8r j9h70CZcR31jH/JH3PYeREIf1qPeqPepQsuhT6A3O9wP0IIiTb1DsL/oa65aLA8PzbNi MK+O+qIw8MTMwXrh0Ye2OciaV71iBrdPQFrtM0EcNP4XlxO5tXg/Kl+cDprv2skm4RZJ RA9TsEejSxdWmZqdRWr0nw4OZ9WhFKyPp0Nxp06TaFpInPl2xWIbLTM5w9DluaEUBF6c gWjFi/sPcgNUK4jF91+cxn/Z7ohOxyn4MqKdP5Ux39anXNfRLbQwND2BvGYFZ4uomdoW /Myg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794493370; x=1795098170; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+eMaexRE5YK9LKV2U20lRzNlg/Uqk666DN6/XsuIY9E=; b=QmyDbV3NyeWCLphWpK84RqYlMeEV/Qk837CXdnhVapc23UdH9zuxfzdof4RkyUpRx2 rSOlbWrksvgOYK55bBt63gYStMUQDONphvMrkOLsvMcylTwc30+yHfGGol/qb/5uSt5z +kQvugyrZ32I1jdinCpaAZGkz1k89DaFO/QulQ88qc2L+n+K3Ul3ZVF+S7BxGWEu65J9 wLq2IU2H9hJCNzPTZdeBjH/uwhHVMOqPNBqZbyVvs/eP5GNJ4zY+Vx5BUC4EtBpPvDPM ZqPWv38yFtY6yj+F6/Aajeg7Vey0NMImQUjh9j7P7sKaMTiBXsDzgi6+RADDGK26XF2G sIiQ== X-Forwarded-Encrypted: i=1; AL+hErGf0SgRmRbP1Z5+Ib5D51ILunWducVIc+6ek19JScmc4qoThmVD3C3z27Fe0i2rkLsu7XS//+RcAWiCuyw=@vger.kernel.org X-Gm-Message-State: APuU4Z8FSP4F1cmr6YZSebq/J+VQ0dy0gwx5vKexbOCCRSTlNvMQNamK c6tN5kDOe/CBLypAS4E+HoIRImaonqPI9vjaV5dFCHPq3hvzo3tLNfmoJ3XMUcAx/GntLoiaPkq f6CvP+GwuxipdL437rg3FUOpH6NCNa/gdqWCs1idnGt39eZgCaiUIx3ZXfNLCXznCwucLv/ggFa 4= X-Gm-Gg: AYBFou0vExgjlLIAbCfXxprZvTC+z9Ty+YpjOFebSq8ch4gG1ELKOKno4YEI+f923TR PijkIJAR+hTAFkHPKEYPYuMiNiUh9IsKlqLLtVlYC9CjGCG9AHm2G8EuOHyRcVSVoqiekil0nB+ 9wqjYT9iy6X08had9y1yEcjhbS3d/RTKaUOC5ErXYFdF107b919TRBS49rCUjV3UoMJMszAP4HW Mf8Jq+RPd5gB7Pcd0Uds7/GsvekdQTx7bV935YpEE7FLJDD4oVwC92hbulIvqUvZ6wOtKw4uJ02 40PO77Qnz3aZYexxmwAkPskqrB8iIxgB8Wjr81Sw7H/K6Fsu9YVFFJ21QWEssDNl/qSmr/9Zy2b eeujWKw75iVaqx5cdhtDfFGyzmfKIFI2PFIbHnqt4Z+/C3kjilHIXuHyDxD2xyLLeLY6qr+PGS0 nU X-Received: by 2002:a05:6a00:400a:b0:89e:6bef:70f9 with SMTP id d2e1a72fcca58-8bc1cd630b4mr6052251b3a.27.1794493369799; Thu, 12 Nov 2026 06:22:49 -0800 (PST) X-Received: by 2002:a05:6a00:400a:b0:89e:6bef:70f9 with SMTP id d2e1a72fcca58-8bc1cd630b4mr6052205b3a.27.1794493369238; Thu, 12 Nov 2026 06:22:49 -0800 (PST) Received: from [10.206.111.19] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8baa7bf82b1sm3659638b3a.8.2026.11.12.06.22.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2026 06:22:48 -0800 (PST) Message-ID: <3cb96b5b-d061-4f0d-919b-09c6f336e453@oss.qualcomm.com> Date: Thu, 12 Nov 2026 19:52:42 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports From: Nihal Kumar Gupta To: Loic Poulain , Bryan O'Donoghue , Krzysztof Kozlowski Cc: Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Conor Dooley , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Vankadara , Vikram Sharma , Krzysztof Kozlowski References: <20261102-glymur_camss-v1-0-fcb619fc7319@oss.qualcomm.com> <72064a9a-1b2e-4c24-99e2-2cc15a8dd7f1@oss.qualcomm.com> <539842db-c672-4549-b861-4a6f3be47556@oss.qualcomm.com> <1db9bf48-01d8-44fe-8dd2-7a3c84ecc556@kernel.org> <62fba00d-831c-44cc-8d3e-083a95abfbe8@kernel.org> <3df59469-e665-4901-b4b4-512604194ddd@kernel.org> <5e0f4424-7194-413a-af7c-f6e74d07392b@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <5e0f4424-7194-413a-af7c-f6e74d07392b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: KU6-4FdPFL5ypzontWkKzlWbO_KinPO5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEyMDA1NyBTYWx0ZWRfX53EU98eVsltk zPRpePuIgJiWkqrGdVzcKmmNPFBcXh+CahQ9x2M8ncRO/MtfqZlWBhMzQbLZ7xXiG1tL95dnfMJ OPL5ow4DyBxIzwboDX8wr8Xbc5HWcnV/QRtWLjKCKMUDHyBDPhUsPlGEIFOAQpXNkWxa0npXSgR ByHDuvgPSs2F94uisaQpjlRX0hOD3+mshckGplG1AX5hm8BRhNkem2Ax5a+v1ubivnQllbIVlIl IbqW8SRHD2x5983/OAygdFuPje/bJaIAkl2a67baevzPERipSuMwNgDPz7Vq/ilkaG/da7xVtvT 9e/Qea3XXS6u4RwPNhGOrGGO/u2y376sCOKtfBImntejJtoS6ej/FeOGufUmCR4sX/gT1D5QQY0 3BxddPR/zSaqc0HEgAEJ349X70ZJtEv5blugAZxbNEE6H+X5uFVUyqBq/Ehr3tkhJz9SwOLPiwZ K7hILgkb7XLs+0HVH3w== X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEyMDA1NyBTYWx0ZWRfX2mDR9x/08R5q c7XzAMyT8zPLjXoJhpvj8qhwhcXe5seVyKZNNZx/SjkzI8klEQbW70LqUPq/QRhulsDdycpXm/K I2dOQ3FneWzEejB0fxfcgiGg4D0+59k= X-Proofpoint-GUID: KU6-4FdPFL5ypzontWkKzlWbO_KinPO5 X-Authority-Analysis: v=2.4 cv=O/ysLx9W c=1 sm=1 tr=0 ts=6af5cbbb cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=k8_bfzPL0-wbRAlyoaUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-12_01,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611120057 On 09-11-2026 11:35, Nihal Kumar Gupta wrote: >> So yes, we could argue that the port ID itself has no inherent >> meaning, but it acquires meaning through the convention we define, >> since we still need a way to map DT ports to CAMSS input IDs. What is >> really changing here is the convention used to describe that mapping. >> So, for Hamoa, ports { 0, 1, 2, 3 } would map to CAMSS PHY inputs { 0, >> 1, 2, 4 }, while for Glymur, ports { 0, 1, 2 } would map to CAMSS PHY >> inputs { 0, 1, 4 }. >> > Thanks Loic, Bryan, Krzysztof and Vladimir for the discussion. > > Krzysztof, understood on the DT binding concern. I should have got clear DT > maintainer agreement before proposing a binding semantic change, and I will > keep that in mind for future changes. > > Based on the discussion, I agree that for standalone PHY CAMSS DT input ports > should be logical and linear. For Glymur, that means using ports@0-2 { 0, 1, 2 }, > and keep the mapping to hardware PHY indices { 0, 1, 4 } inside the driver. > > Krzysztof, does this direction sound aligned to you? If yes, I will respin > accordingly and make sure the commit message documents the logical-port to > hardware-PHY mapping clearly. > Krzysztof, the Glymur CAMSS binding is already merged, but no upstream DTS consumes it yet. The current example uses port@3 for CSIPHY4. For the binding, would you prefer keeping the existing "^port@[0-3]$" range, or tightening it to "^port@[0-2]$" and using logical ports port@0, port@1 and port@2 in the example? The driver would then handle the mapping from logical port 2 to hardware CSIPHY4. >> If you look at the mdss_mdp ports in glymur.dtsi, you'll notice that >> the ports are associated with their corresponding INTF numbers, and >> interfaces that are not present are simply omitted. As a result, the >> port numbering contains holes, for example {0, 4, 5, 6}. >> >>> Honestly I don’t see much value in continuing to treat port numbers as >>> hardware mappings in DT now that standalone PHYs have landed. >> As long as it is clearly documented in the binding, that should be >> fine. We will need to introduce a mapping table for platforms that do >> not expose the legacy PHY numbering, or otherwise derive the >> corresponding information from 'somewhere'. -- Regards, Nihal Kumar Gupta