From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98341C352AA for ; Tue, 1 Oct 2019 15:03:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E1462168B for ; Tue, 1 Oct 2019 15:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="f8M2abPJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389415AbfJAPDN (ORCPT ); Tue, 1 Oct 2019 11:03:13 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:43366 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfJAPDN (ORCPT ); Tue, 1 Oct 2019 11:03:13 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x91F2tBo017997; Tue, 1 Oct 2019 10:02:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1569942175; bh=FtGKw7kQQovEcABguQcARfmvU81jXg7GbjUfgsdw1Q4=; h=Subject:To:References:From:Date:In-Reply-To; b=f8M2abPJ5E2aPEAh8yZeVPhhazCotY06RboI3cv1WILlrmTEBfP4Mg331gud3ggIu sKf/jLzbNpsnvvV1kbHR6GzbhnKOS5pX83i9/nQjXYx65/DW9J7ndM17sktKdcG5k5 lwn04f+tpDpmFR/k7cCrgSRN2vfToIiYb5dftpKo= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x91F2tJE014138 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 1 Oct 2019 10:02:55 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 1 Oct 2019 10:02:55 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Oct 2019 10:02:45 -0500 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x91F2swW029639; Tue, 1 Oct 2019 10:02:55 -0500 Subject: Re: [PATCH V6 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c To: Kiran Gunda , , , , , , , , , , , , , , Andy Gross , , References: <1569825553-26039-1-git-send-email-kgunda@codeaurora.org> <1569825553-26039-2-git-send-email-kgunda@codeaurora.org> From: Dan Murphy Message-ID: <3cbc14db-9d6d-f60f-eb92-4b4d80d3774d@ti.com> Date: Tue, 1 Oct 2019 10:03:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1569825553-26039-2-git-send-email-kgunda@codeaurora.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: > pm8941-wled.c driver is supporting the WLED peripheral > on pm8941. Rename it to qcom-wled.c so that it can support > WLED on multiple PMICs. > > Signed-off-by: Kiran Gunda > Reviewed-by: Bjorn Andersson > Acked-by: Rob Herring > Acked-by: Daniel Thompson > Acked-by: Pavel Machek > --- > .../bindings/leds/backlight/{pm8941-wled.txt => qcom-wled.txt} | 2 +- Instead of renaming this file would it be more maintainable to indicate in the pm8941-wled.txt to reference the qcom-wled.txt file for complete description? I will let Rob comment on maintainability. Dan > drivers/video/backlight/Kconfig | 8 ++++---- > drivers/video/backlight/Makefile | 2 +- > drivers/video/backlight/{pm8941-wled.c => qcom-wled.c} | 0 > 4 files changed, 6 insertions(+), 6 deletions(-) > rename Documentation/devicetree/bindings/leds/backlight/{pm8941-wled.txt => qcom-wled.txt} (95%) > rename drivers/video/backlight/{pm8941-wled.c => qcom-wled.c} (100%) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt > similarity index 95% > rename from Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt > rename to Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt > index e5b294d..fb39e32 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt > @@ -1,4 +1,4 @@ > -Binding for Qualcomm PM8941 WLED driver > +Binding for Qualcomm Technologies, Inc. WLED driver > > Required properties: > - compatible: should be "qcom,pm8941-wled" > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 8b081d6..6ff3176 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -284,12 +284,12 @@ config BACKLIGHT_TOSA > If you have an Sharp SL-6000 Zaurus say Y to enable a driver > for its backlight > > -config BACKLIGHT_PM8941_WLED > - tristate "Qualcomm PM8941 WLED Driver" > +config BACKLIGHT_QCOM_WLED > + tristate "Qualcomm PMIC WLED Driver" > select REGMAP > help > - If you have the Qualcomm PM8941, say Y to enable a driver for the > - WLED block. > + If you have the Qualcomm PMIC, say Y to enable a driver for the > + WLED block. Currently it supports PM8941 and PMI8998. > > config BACKLIGHT_SAHARA > tristate "Tabletkiosk Sahara Touch-iT Backlight Driver" > diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile > index 63c507c..6f87770 100644 > --- a/drivers/video/backlight/Makefile > +++ b/drivers/video/backlight/Makefile > @@ -48,8 +48,8 @@ obj-$(CONFIG_BACKLIGHT_OMAP1) += omap1_bl.o > obj-$(CONFIG_BACKLIGHT_OT200) += ot200_bl.o > obj-$(CONFIG_BACKLIGHT_PANDORA) += pandora_bl.o > obj-$(CONFIG_BACKLIGHT_PCF50633) += pcf50633-backlight.o > -obj-$(CONFIG_BACKLIGHT_PM8941_WLED) += pm8941-wled.o > obj-$(CONFIG_BACKLIGHT_PWM) += pwm_bl.o > +obj-$(CONFIG_BACKLIGHT_QCOM_WLED) += qcom-wled.o > obj-$(CONFIG_BACKLIGHT_SAHARA) += kb3886_bl.o > obj-$(CONFIG_BACKLIGHT_SKY81452) += sky81452-backlight.o > obj-$(CONFIG_BACKLIGHT_TOSA) += tosa_bl.o > diff --git a/drivers/video/backlight/pm8941-wled.c b/drivers/video/backlight/qcom-wled.c > similarity index 100% > rename from drivers/video/backlight/pm8941-wled.c > rename to drivers/video/backlight/qcom-wled.c