mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Andrei.Stefanescu@microchip.com>
To: <axel.lin@ingics.com>, <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <Cristian.Birsan@microchip.com>,
	<Claudiu.Beznea@microchip.com>, <Nicolas.Ferre@microchip.com>
Subject: Re: [PATCH] regulator: mcp16502: Fix missing n_voltages setting
Date: Wed, 19 Dec 2018 11:45:06 +0000	[thread overview]
Message-ID: <3cc3ff18-e0e1-76e7-16ef-56b17831aa8c@microchip.com> (raw)
In-Reply-To: <20181219085804.9601-1-axel.lin@ingics.com>

Hi Axel,

Thank you for the patch!

However, there are not MCP16502_VSEL + 1 voltages,
but VDD_HIGH_SEL - VDD_LOW_SEL + 1 (=51).

Best regards,
Andrei

On 19.12.2018 10:58, Axel Lin wrote:
> The n_voltages setting is not set, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>   drivers/regulator/mcp16502.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c
> index 25d7b433fafd..ec5b6836a20c 100644
> --- a/drivers/regulator/mcp16502.c
> +++ b/drivers/regulator/mcp16502.c
> @@ -90,6 +90,7 @@ static unsigned int mcp16502_of_map_mode(unsigned int mode)
>   		.ops			= &(_ops),			\
>   		.type			= REGULATOR_VOLTAGE,		\
>   		.owner			= THIS_MODULE,			\
> +		.n_voltages		= MCP16502_VSEL + 1,		\
>   		.linear_ranges		= _ranges,			\
>   		.n_linear_ranges	= ARRAY_SIZE(_ranges),		\
>   		.of_match		= of_match_ptr(_name),		\

      reply	other threads:[~2018-12-19 11:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19  8:58 Axel Lin
2018-12-19 11:45 ` Andrei.Stefanescu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cc3ff18-e0e1-76e7-16ef-56b17831aa8c@microchip.com \
    --to=andrei.stefanescu@microchip.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Cristian.Birsan@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome