mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-afs@lists.infradead.org, David Howells <dhowells@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: afs: Improve exception handling in afs_net_init()
Date: Mon, 1 Jun 2020 21:34:26 +0200	[thread overview]
Message-ID: <3cc663a5-088d-4d26-34cd-c96e362c1eb2@web.de> (raw)

Hello,

I have accidentally taken another look at the implementation of
the function “afs_net_init”.
I noticed that the statement “net->live = false;” was specified three times
for exception handling at the end.
https://elixir.bootlin.com/linux/v5.7/source/fs/afs/main.c#L127
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/afs/main.c?id=9bf9511e3d9f328c03f6f79bfb741c3d18f2f2c0#n127

Can it be that two of these assignments are redundant then?

Regards,
Markus

             reply	other threads:[~2020-06-01 19:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 19:34 Markus Elfring [this message]
2020-06-01 21:11 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cc663a5-088d-4d26-34cd-c96e362c1eb2@web.de \
    --to=markus.elfring@web.de \
    --cc=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®