From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEF453AF677 for ; Wed, 1 Jul 2026 15:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782918217; cv=none; b=jS5+NRVY9Ggwj5hP2eY1R/xoxvshHrjW+8WfWgyYWItYddzfKCxyh/+pdOxELAm6CkNP05jJpmAUNBtr+ktwD+x6U1wcZWTq7mHD+TZqXV66OjGEdmzzv3Wj5HNCKqNJpTXgDxsFlhCJgjZII4iAzmRFyyVRUZPeAgtDJT38AWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782918217; c=relaxed/simple; bh=mPa032KjVqhep+LmasmgeIXAJMos05zkPxFZEAw3UIw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TPgnilmKaeibuZUzg6apjk3CIzMFhmsJ8FGT3vB96HOh6MyeSQCHYQRHL5zaB/gHdiYuRBdxED2PDucc92zoiBW2/S+Jlirwcl2KoZnGIIXwaYwiozbDQ46ASkuQEuH6plCGhWii+Q9czyzfVXlAARxGXzd7teZRs8JoJFm35yM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PM9TA8JP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iXVynEl5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PM9TA8JP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iXVynEl5" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661A8tk5762327 for ; Wed, 1 Jul 2026 15:03:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PMlxy+ySrUpTNuoFj21YmLboTEdtjJH/cjm/SS08cO4=; b=PM9TA8JPXdauBw2F iXt0L+44k6OnEzA4NKbnzVJMPoAUtyalWHrq5uQU0lfNdcp0SppnW2HpEkhSg7zk 4FPVx3AtU4h5ZZiq6fGCz9OjK0mqEWjmCJFwTYiuhrEc3EqmOUcwbZUxqIhjqFDQ rgZV4KgXN+fsXU7+YytOCDUv5aVg+L67+j/K6TeH5ZLFLfOxtVPBGEUyrO6iOYQY jElbu30jtIBxxC5JGSpUXm0nRQZ4V6F5BNbYLsEdmjj3lt/kYwuKzlFjn/HEcelt kc450xgQo9AlbybbZfvW9lUN7v0GhXKaQPNvUGonpiopaAoRBiJWdJJ0hUzVOaka sEJhfg== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f50sd1811-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 15:03:33 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7e99ff505c2so584331a34.1 for ; Wed, 01 Jul 2026 08:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782918213; x=1783523013; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PMlxy+ySrUpTNuoFj21YmLboTEdtjJH/cjm/SS08cO4=; b=iXVynEl5U+oRsJZJgomfhMRG5sCunQM9du3jyTsya5+wDD3ihTzWIzoivV+XtfsWp3 aYnpXD95YLsWetVRfjElF2mEQX8ge4qkcR6lr3g1TCvia2/WEiIc+zjU5zGaeeTnDIVB lK0PFeyq69TMD6s8sSpF+vmydgEiEzvftksA1DyhfnvWU8fvr6wnsl0V08vW05+Lqr0m RC2N3qMVsrlrFnIyB1AHdkS2txMVvuN59rpy9ONkBoB1pbX4dOdS4M2LI1Js+Svni0Jc PKPbu7IzPOMYn9dIjL6Lnf+KSP+gFQvWVAcSJ7IMXwifY4ZB6Oeri6Jn4jPjSz6CZRe2 uQDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782918213; x=1783523013; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PMlxy+ySrUpTNuoFj21YmLboTEdtjJH/cjm/SS08cO4=; b=l7857JHwJJujy25CA9ywHzOte5Bc2YdYzaUUA8fxaERndCkxjgJiDwPJgJzA08eAwA bUWU7coXTAxcHtbiWgYgLd2M4Qp/b6vC5+7jeLdzhCTvG3I2y5LWqdJZhgJ+3zBGM8ms KujG9s+q7UcdpI+dgbHi0LRlTfMDiz/RHQ0+o/EY12tk2blIYBEguVTPsEa8sqyz77Dj MCgWcM6UsDFrKvHhMdSEA1AW3vFRYAPstVT8KIc40Ctv+BnVtD1DIitUb2/CCMtuoT9S bKJn7iBT9TCzZvYNgAtvBlHz24QNxJttWvEJeEsQ1510RNLUg64aMY5OevkejZTZGGWg x+5g== X-Forwarded-Encrypted: i=1; AFNElJ9+WzD1x7fm1kpBgVa3rcGqID6zPBxLJoEI8+FIfCpRVLkm+Hm5SBCxzBHeVmiybfqNRHVfq2ekLEcLYow=@vger.kernel.org X-Gm-Message-State: AOJu0YwI0Ekfrj01cBH4zJVIINeKLFghnsyS52GxAYd2oe0ekgWV3cvz y65Nxo60f3QLrlg8OXxUwv6ByZf12tnHc0ozuaWEthR8+W6+7b+temEnB/3yTyWB4jeoscdcwhh GS9L4/3pObFGzAvOiP3UuUHv/USvhJc/YHpcsKxs00JNLYHzIRMIIML2PovtXUd7oM7Q= X-Gm-Gg: AfdE7cn3QVWZtZkqr3FceNE6CkXYgx/pWrZ+xfT6rnjgD03Z620O8WvZWMgeYgaQpbB ct1Wx4VvFqpbOMUMpEPFHZd/p8EycI8HS3+kNYic+tBJlEBZhQcBbk+uzwPSE4kXA/YwsXNv3OW qZrKJv/OFZZB3yQb9ddErJyxWg4JvuvxaPhLyRwmigLbbBUZHxGcwyW8PjO1SsrXcIpd3WwdpyH K5fby6j4kOM1yY2qSyffcFulvKNlNWyzyv6usrpyoJu1QGYsy5C58zG1mOq0x1kUwxdjLMMyz2C E/Vnbt3Px34QKVmpwkAlchEmVhVNBBavc7BUjfkHfw1P+QbM2/lKahtjvEYFE0ma6C6tMzwS+Ql XLejIRtZsVsYGJZf5JHhS8wx90i4o7pYW28pIqI7bUi9BosX7OIYONAL4zscwyQ== X-Received: by 2002:a05:6830:dc3:b0:7dc:c4ae:a689 with SMTP id 46e09a7af769-7eb48ab9e3fmr979309a34.2.1782918213181; Wed, 01 Jul 2026 08:03:33 -0700 (PDT) X-Received: by 2002:a05:6830:dc3:b0:7dc:c4ae:a689 with SMTP id 46e09a7af769-7eb48ab9e3fmr979230a34.2.1782918212633; Wed, 01 Jul 2026 08:03:32 -0700 (PDT) Received: from [192.168.69.212] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6988270903fsm2379453a12.11.2026.07.01.08.03.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 08:03:30 -0700 (PDT) Message-ID: <3cc822f4-ee86-447b-80d4-d0e38816ce3d@oss.qualcomm.com> Date: Wed, 1 Jul 2026 17:03:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/11] KVM: x86/xen: Consolidate checks on Xen vCPU ID for singleshot timer hypercalls Content-Language: en-US To: Sean Christopherson , Vitaly Kuznetsov , Paolo Bonzini , David Woodhouse , Paul Durrant Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+5b32c49cd8f005e65654@syzkaller.appspotmail.com, syzbot+5d2b94b77112148d1744@syzkaller.appspotmail.com, David Woodhouse References: <20260630225619.511632-1-seanjc@google.com> <20260630225619.511632-6-seanjc@google.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20260630225619.511632-6-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Z+3c2nRA c=1 sm=1 tr=0 ts=6a452c46 cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=pBOR-ozoAAAA:8 a=1XWaLZrsAAAA:8 a=EUspDBNiAAAA:8 a=exR_2C3_D3Cxa9Nl7fQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-ORIG-GUID: A8wWNcaAVl2BO0BZ8KmFKCLDMvqcRNuv X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDE1OSBTYWx0ZWRfX1WC0m/wetIMo SX/NBxwoxL/3kPYB0g8wN02/ef9jBlLFtaKptWTx+Y01ujZNz/lBkkgcYvom4daRZ2fhAxkWg3k SjHo7Oj0pkI41W+0wqFS65fIX22QHE0= X-Proofpoint-GUID: A8wWNcaAVl2BO0BZ8KmFKCLDMvqcRNuv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDE1OSBTYWx0ZWRfX2YQzW5WB+9Fs ffBrpR+zdXBR0K4aRfXOxt0EpuQ8YFIezfNzsLSXojD69YMz8YZLNCBv927HQZRKE1u3hZjhiUX 1WGzYgIcGbPyXVBEZvte7kQoIUxUMhpkq9VXNGsSF73xPaCbHBW6x5w93QC5pt1+gkMF0Z769Ij cS4k9dfvQkyoVud+lO0U/17SJ9OLTvH4RQCMAoWxvZch9MkFtUuKpnvocafGC0KD8oF3wn2Ey1z a4DyJi9mUgPsBhfC2YWQgmDDiOAbXXbjhzofGK1i/ZWanlOBn97NMK2GmozZiE7wFun98SBZF5l ptDh6gotiTEanv6Xl5hKO8F6Jd4EXeMkw5y2ID48SEUmdOHymZb9og11iCxUrfWpK4oVta12EJg oXL6EOFPI3LIduQKTLDhUC2UpRA9RZvhROkBYIbGm9VpzET9UXAg+SblV0UPBtDKGPfh4tvucoa 1xnTAIy9w2LI00Am9Rg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010159 On 1/7/26 00:56, Sean Christopherson wrote: > Hoist the checks on the Xen vCPU ID when handling set_singleshot_timer and > stop_singleshot_timer hypercalls out of their individual if-statements, > so that both checks on the ID are in common code. kvm_xen_hcall_vcpu_op() > is already doubly committed to handling only singleshot timer hypercalls, > and even if that were to change in the future, the function could simply > be renamed and turned into a helper specifically for timer hypercalls. > > Opportunistically add a comment to explain why the check exists; the code > looks rather nonsensical without the knowledge that @vcpu_id is a common > param for all per-vCPU hypercalls. > > No functional change intended. > > Reviewed-by: David Woodhouse > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/xen.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé