From: David Heidelberg <david@ixit.cz>
To: Kuen-Han Tsai <khtsai@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Val Packett <val@packett.cool>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: u_ether: Fix NULL pointer deref in eth_get_drvinfo
Date: Thu, 26 Mar 2026 17:37:47 +0100 [thread overview]
Message-ID: <3ccc2539-220f-4a2b-88ad-c7d26dd4be8f@ixit.cz> (raw)
In-Reply-To: <20260316-eth-null-deref-v1-1-07005f33be85@google.com>
On 16/03/2026 08:49, Kuen-Han Tsai wrote:
> Commit ec35c1969650 ("usb: gadget: f_ncm: Fix net_device lifecycle with
> device_move") reparents the gadget device to /sys/devices/virtual during
> unbind, clearing the gadget pointer. If the userspace tool queries on
> the surviving interface during this detached window, this leads to a
> NULL pointer dereference.
>
> Unable to handle kernel NULL pointer dereference
> Call trace:
> eth_get_drvinfo+0x50/0x90
> ethtool_get_drvinfo+0x5c/0x1f0
> __dev_ethtool+0xaec/0x1fe0
> dev_ethtool+0x134/0x2e0
> dev_ioctl+0x338/0x560
>
> Add a NULL check for dev->gadget in eth_get_drvinfo(). When detached,
> skip copying the fw_version and bus_info strings, which is natively
> handled by ethtool_get_drvinfo for empty strings.
>
> Suggested-by: Val Packett <val@packett.cool>
> Reported-by: Val Packett <val@packett.cool>
> Closes: https://lore.kernel.org/linux-usb/10890524-cf83-4a71-b879-93e2b2cc1fcc@packett.cool/
> Fixes: ec35c1969650 ("usb: gadget: f_ncm: Fix net_device lifecycle with device_move")
> Cc: stable@vger.kernel.org
> Signed-off-by: Kuen-Han Tsai <khtsai@google.com>
> ---
Works for us in sdm845-next too,
Tested-by: David Heidelberg <david@ixit.cz>
--
David Heidelberg
prev parent reply other threads:[~2026-03-26 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 7:49 Kuen-Han Tsai
2026-03-26 15:24 ` Aelin Reidel
2026-03-26 16:37 ` David Heidelberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ccc2539-220f-4a2b-88ad-c7d26dd4be8f@ixit.cz \
--to=david@ixit.cz \
--cc=gregkh@linuxfoundation.org \
--cc=khtsai@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®