From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: memory: tegra: Document #interconnect-cells property
Date: Tue, 23 Nov 2021 20:53:49 +0100 [thread overview]
Message-ID: <3ccecc07-5e76-125a-8bcb-12219af5983c@canonical.com> (raw)
In-Reply-To: <20211112130627.3682795-2-thierry.reding@gmail.com>
On 12/11/2021 14:06, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The #interconnect-cells properties are required to hook up memory
> clients to the MC/EMC in interconnects properties. Add a description for
> these properties.
>
> Also, allow multiple reg and interrupt entries required by Tegra194 and
> later.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../memory-controllers/nvidia,tegra186-mc.yaml | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> index 611bda38d187..f6e4af4e86cf 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
> @@ -33,10 +33,10 @@ properties:
> - nvidia,tegra194-mc
>
> reg:
> - maxItems: 1
> + maxItems: 3
>
> interrupts:
> - maxItems: 1
> + maxItems: 2
All these here and reg below might need if-else to define when one item
is allowed, when not. For example - can nvidia,tegra234-mc come with
only one reg?
Except this and Rob's DT-checker-bot rest of patches look ok to me.
Best regards,
Krzysztof
>
> "#address-cells":
> const: 2
> @@ -48,6 +48,9 @@ properties:
>
> dma-ranges: true
>
> + "#interconnect-cells":
> + const: 1
> +
> patternProperties:
> "^external-memory-controller@[0-9a-f]+$":
> description:
> @@ -65,7 +68,7 @@ patternProperties:
> - nvidia,tegra194-emc
>
> reg:
> - maxItems: 1
> + maxItems: 2
>
> interrupts:
> maxItems: 1
> @@ -78,6 +81,9 @@ patternProperties:
> items:
> - const: emc
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-11-23 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 13:06 [PATCH 0/5] memory: tegra: Add Tegra234 support Thierry Reding
2021-11-12 13:06 ` [PATCH 1/5] dt-bindings: memory: tegra: Document #interconnect-cells property Thierry Reding
2021-11-12 23:05 ` Rob Herring
2021-11-23 19:53 ` Krzysztof Kozlowski [this message]
2021-11-12 13:06 ` [PATCH 2/5] dt-bindings: memory: tegra: Add Tegra234 support Thierry Reding
2021-11-29 21:00 ` Rob Herring
2021-11-12 13:06 ` [PATCH 3/5] " Thierry Reding
2021-11-12 13:06 ` [PATCH 4/5] arm64: tegra: Add memory controller on Tegra234 Thierry Reding
2021-11-12 13:06 ` [PATCH 5/5] arm64: tegra: Hook up MMC and BPMP to memory controller Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ccecc07-5e76-125a-8bcb-12219af5983c@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®