From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39897398FAB for ; Thu, 4 Dec 2025 23:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764890420; cv=none; b=aMd2HXi7MDiA4iFJUd4pMcmrtzCqef82FPd18JJQAokDCm5RLdKFGXQdwTW87sK0746gGyRT/7+8/PgkB55ujM1Sjcb6Ld9w+Bdt0k3dtfjjY3VJtPhldBpShH1vbcR2WvTm970mFoVhBulLt4C05Q+hvVPGzs0iM6GBMFu26bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764890420; c=relaxed/simple; bh=r2wo/pMRq4RWI0wKSzCI+Li8QqdeVTWp8GC1qqHNzr8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f/Khx2USKR6FZqc4f308rrR9BXeD/dp9RBTXtm2JDJJuP9f3fyOfRzEt8JSFq6HBRcIMcRiSd180x8WponCQ4KeljJdJuXuj+X0cNX0ThIVccwt2xuffetnZwxHcl9E9+XX63wN+9U05cmtHDZVAIBXBERSIZAZlD6FbcMlX+9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=grnLHgrX; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="grnLHgrX" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-3eae4e590a4so712295fac.1 for ; Thu, 04 Dec 2025 15:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1764890417; x=1765495217; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1ilabqU0ZPIRb1Uuq8o42HfQ+CvcrcgaYSOj/pymfPA=; b=grnLHgrXXY2CYLgirw4B07WDgls+RnxZh89tr8LDNIaH3fHTaYhUc5FxLgRowVpccS lnLlDRsK0Jf6ELGUhOa2UfERR1CRQCeN7NKK00CN7hJFtekW+hU/bu/3OeMZllDl/WV1 VbaK5RSzWZ7kDgoozcanU1WJrwcQhe3oTlbNQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764890417; x=1765495217; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1ilabqU0ZPIRb1Uuq8o42HfQ+CvcrcgaYSOj/pymfPA=; b=P08BWmWYauAnnnLDvLOErFnoQ6uFx+nj4GWahTx+4AvPEV67CZ2oBmTcLUMPpDIM3c 8tGvunheZQK3pT9mmzm0hURyLWsow0dE0uVti7pV1i1c8Vid6efleR6VdTuyMbo67olz ehMuiYbCpQgDOROCGoJdmQhCRvrZuW3XE1HDcd2lT91YgWtIedLD7n/CZjNkeN0MWM8a VUsqhNrHJ6zMpKcd2J9HZLVNqofkO5ohHZkQVXWr8ZsM/EzKT3Q4tKdTtAyL9Fn7a77f MKg8V0SPKig8patyp/y7tLEMnTAYwH1A15v7g13p4fiYwaHyAatfHGFqj/81euFJAUQi 8iJw== X-Forwarded-Encrypted: i=1; AJvYcCUQhCzj1Rx0Khuf0oN7mV0n3Ivf/TkzpecPwVMm7l9nd1U6armD1wotj/1pDSvutZVZUfwS3OJh+WBJNOo=@vger.kernel.org X-Gm-Message-State: AOJu0YytH+S5/qUAtDfRWyynIzNX8Cv78vk1pTZ0sw0psewynvm1Ptyr iRl5u44B9ITHQGOJhSRwusfQDfvVYUykAW8Py8AZZe1gWO23AWIngBvBYPQSvFmR5xU= X-Gm-Gg: ASbGncuViTK6r+G3S9IXiKQNY0FEKCwPSuCgj9n+x6k/nN2DWkFjzK2R2m2ovmG4yNc wyzjV87mAqG5WGsehR+P6tXULdLUEh5yIH3CkADmLbzRconUQk5p/2KBaDLmENXew+nRNPnMc2s SqwSICBEEydUX1vtEEpqIsdkHb3gjAs2HRXJxtTt/H7zEfMfZuqKrf382eslXfurf8LNzQ2/AYn ANoejvf/Zd6WxcUty2PLq8w7Mq7AEjnNpAc45hMenmrg/fwoJQsJfk0VTJQIoES6dvo+M1jc/Tt reuA4PH5T+zP4LUUJ4i7mUOLkp/qsb8DOmOlcBVO/kyj+3AkaPS16lg5ofKojaG0mxYeTHO774z UVBdLDd7pX5Io2N9iESE31UeGtZAeqiBrPH+kKPhUYxmkP2XHHePWd+GgobVOZWNZEuCIgh2z/3 qG1YY2mAP7vkBq6UWuw1HrJ1w= X-Google-Smtp-Source: AGHT+IEWl3G9taWVAc0FXunulp0EUlwKR0OqZ4+JiONHzArIhRnKO+2ONevOYyoQ9T+k/jyvf8v9NA== X-Received: by 2002:a05:6870:ec8b:b0:3ec:4e22:bbb0 with SMTP id 586e51a60fabf-3f1691d07f6mr3791225fac.18.1764890417156; Thu, 04 Dec 2025 15:20:17 -0800 (PST) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3f50aa9ed65sm2288970fac.7.2025.12.04.15.20.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 15:20:16 -0800 (PST) Message-ID: <3cd2240b-ec2c-45d0-b73b-b66c83e75b9f@linuxfoundation.org> Date: Thu, 4 Dec 2025 16:20:15 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux 6.18 amdgpu build error To: "David Hildenbrand (Red Hat)" , Linus Torvalds Cc: akpm@linux-foundation.org, Alexander Deucher , Linux Kernel Mailing List , amd-gfx@lists.freedesktop.org, dri-devel , Guenter Roeck , Linux Memory Management List , Shuah Khan References: <74032153-813a-4a40-8363-cce264f4d5ea@linuxfoundation.org> <1eb24816-530b-4470-8e58-ce7d8297996c@roeck-us.net> <0425d7b4-76e4-4057-83a5-a7b17a051c54@linuxfoundation.org> <9d520a1d-0b8d-4d30-b29f-230fc0f92b8a@linuxfoundation.org> <1f31b86d-283c-4878-92d0-ab90aed0c58d@roeck-us.net> <5af4522e-30ab-4eec-a861-c2760cdabd4f@linuxfoundation.org> <2bc690ca-fa57-46fa-949b-28b5441cd364@kernel.org> <3b6d6e50-91ac-435e-adad-a67d4198a5b5@kernel.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <3b6d6e50-91ac-435e-adad-a67d4198a5b5@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/4/25 12:45, David Hildenbrand (Red Hat) wrote: > On 12/4/25 20:36, Linus Torvalds wrote: >> On Thu, 4 Dec 2025 at 09:40, Shuah Khan wrote: >>> >>> This commit has impact on all architectures, not a narrow scoped >>> powerpc only thing -  it enables HAVE_GIGANTIC_FOLIOS on x86_64 >>> and changes the common code that determines MAX_FOLIO_ORDER in >>> include/linux/mm.h >> >> So I suspect your bisection might not have worked out, and there might >> be two different things going on. >> >> In particular, hugepages were broken in 6.18-rc6 due to commit >> adfb6609c680 ("mm/huge_memory: initialise the tags of the huge zero >> folio"). >> >> That was then fixed for rc7 (and obviously final 6.18) by commit >> 5bebe8de19264 ("mm/huge_memory: Fix initialization of huge zero >> folio"), but the breakage up until that time was a bit random. >> Both my systems were running rc6 - I was stuck in a state where I was able to rebase to rc7 and then 6.18, but could never build either one. >> End result: if you ever ended up bisecting into that broken range >> between those two commits, you would get failures on some loads (but >> not reliably), and your bisection would end up pointing to some random >> thing. >> >> But as mentioned, that particular problem would have been fixed in rc7 >> and in final 6.18, so any issues you saw with the final build would >> have been due to something else. >> >> Can I ask you to try to re-do the bisection, but with that commit >> 5bebe8de19264 applied by hand - if it wasn't already there - every >> time you build a kernel that has adfb6609c680? When I suspected rc6 to be the problem, I booted rc5 and compiled 6.18 after reverting 39231e8d6ba based on config file changes between rc5 and rc6. > > Right, that's what I also proposed in [1]. > > I cannot make sense of how 39231e8d6ba could possibly trigger it given that it only affects the value of MAX_FOLIO_ORDER --- which is primarily used for safety checks and snapshot_page(), nothing that could explain changed application behavior, really. > > But while Shuah is retesting, I'll go have a yet another look. I retested on both systems on 6.18 making sure I have 5bebe8de19264 and 39231e8d6ba in there. I cloned linux_next and built it on both. I didn't see any problems on 6.18. Having said that, It might make sense to hold off on including 39231e8d6ba in 6.18 so there is more time to test beyond 2 rc cycles. That is for you all to decide. thanks, -- Shuah