From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C59D3C0015E for ; Wed, 5 Jul 2023 17:17:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232345AbjGERRQ (ORCPT ); Wed, 5 Jul 2023 13:17:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232655AbjGERQ6 (ORCPT ); Wed, 5 Jul 2023 13:16:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDDE519AB for ; Wed, 5 Jul 2023 10:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688577365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T35piQgq4+7zJ5KZwE9xl6DoVBjgPCYheAfovtVFOD4=; b=itHRMICnkB7pLN9/Pu5vpN+XrSTGcjTYyImdDtP8wVqPSI2aKwSIg53XCcjLLlYN/z4hY1 6vMlN7OFW3N9pG93I/UuYjzM539cpOTW0xecg9rtJ/GnL0fP+tbL4jHE996H/CciwxovbT Lmv/H8uZeSWd6c7oOn18RY+rsIxhlqk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-0rHPig1HP-ek_gCFNdaqrw-1; Wed, 05 Jul 2023 13:16:04 -0400 X-MC-Unique: 0rHPig1HP-ek_gCFNdaqrw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fb8284465aso47298905e9.2 for ; Wed, 05 Jul 2023 10:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688577363; x=1691169363; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T35piQgq4+7zJ5KZwE9xl6DoVBjgPCYheAfovtVFOD4=; b=C/S15fKhuGIWUNI31qF+zg7tiFfJZgKYe5+xuPL/ble0syu4wZcugIRewIKv8o3iMu y8F60CjT3MPH+H6UnN9xbB/0OPG85We2NOkxi5GVlbCd39z3aLomDnOhPV2GK5U57NcR f9jzUZySOLo4nv87kdDU/ZYSAH2i/TfugmdZA8WcAzGDzKnxw+NdUtX4G0EgiCxg2h3U tdHnkfVo7pxlo/tO5sz0VxxKX51QMwkwD7r6U1AqX+O08FyXDH8e7QfH41+0XiBBx8BS bMJ8T2gD0QG3NM2oY2WeFjziAwLS2hYcpaF3QOB1uyXls0CU8GttJODesetGLqASLFip hS9w== X-Gm-Message-State: ABy/qLYAwwJts8+n2vtRgOxNbvIZrLR2A8gHVj5f/rUcKr1+x0kB43ZL 9QQHX9vJ0l2ies9bJ2R604hbX8EZ77EMXqyDjE+us/MzLncT9qmpMdJtDppIlRX45yAr3rjgKAA qjeGnJ3SB9AOM7OPMqHHIPhrM X-Received: by 2002:a5d:55d1:0:b0:314:3b9c:f02f with SMTP id i17-20020a5d55d1000000b003143b9cf02fmr6981115wrw.49.1688577363530; Wed, 05 Jul 2023 10:16:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlEUfAcMRX29HqJCQ1c1CH56suwm4NfOCQ9BPaxEr09A1xPnlHPvpu8OfU/EAZeHFIGE5k7pgw== X-Received: by 2002:a5d:55d1:0:b0:314:3b9c:f02f with SMTP id i17-20020a5d55d1000000b003143b9cf02fmr6981094wrw.49.1688577363129; Wed, 05 Jul 2023 10:16:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:1c00:e2b1:fc33:379b:a713? (p200300cbc71a1c00e2b1fc33379ba713.dip0.t-ipconnect.de. [2003:cb:c71a:1c00:e2b1:fc33:379b:a713]) by smtp.gmail.com with ESMTPSA id n10-20020a05600c294a00b003fbaade0735sm2682596wmd.19.2023.07.05.10.15.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 10:16:02 -0700 (PDT) Message-ID: <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> Date: Wed, 5 Jul 2023 19:15:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230705171213.2843068-3-surenb@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.07.23 19:12, Suren Baghdasaryan wrote: > A memory corruption was reported in [1] with bisection pointing to the > patch [2] enabling per-VMA locks for x86. > Disable per-VMA locks config to prevent this issue while the problem is > being investigated. This is expected to be a temporary measure. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 > [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com > > Reported-by: Jiri Slaby > Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cdf51b@kernel.org/ > Reported-by: Jacob Young > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217624 > Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") > Cc: stable@vger.kernel.org > Signed-off-by: Suren Baghdasaryan > --- > mm/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09130434e30d..0abc6c71dd89 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1224,8 +1224,9 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > def_bool n > > config PER_VMA_LOCK > - def_bool y > + bool "Enable per-vma locking during page fault handling." > depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > + depends on BROKEN > help > Allow per-vma locking during page fault handling. > Do we have any testing results (that don't reveal other issues :) ) for patch #1? Not sure if we really want to mark it broken if patch #1 fixes the issue. -- Cheers, David / dhildenb