From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B803129C339 for ; Thu, 27 Nov 2025 09:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764236820; cv=none; b=AxkdpOl+TOCoEu69b2diZeFwL/6uJ2mkDqbRhB8hMBvXO7zTO/j+QFwcuJH6QrCXsvMkt/4L428gRQJJP+0yIBQziu+hI+KN0P2KqS39lTzGdcO4n2sGuu0fStrm1IL6OvjdWfojpKMELQrE1Ks/0QmQk//yodENa/gFIO3yb2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764236820; c=relaxed/simple; bh=8qVHcabnA49Sme4v1DjOvig6KKg3B6BN/BlcApPPU2w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DjtLoRK59RkTfPM05LoFjU9P8Ked2SkpP7PeEbmT1niEWIoqAbluQFkNFRrxhognt8Oqspvgjq1ufeLQF1RY+RxueXysd79gl71cLvZ0Wb7/lL4ihTALga0hKT9nEMSRueIGojgqL6VP0U121E4x5tWIuPkwLgzTeqjDBqmPu7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u48OIx4k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u48OIx4k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B008C4CEF8; Thu, 27 Nov 2025 09:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764236820; bh=8qVHcabnA49Sme4v1DjOvig6KKg3B6BN/BlcApPPU2w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=u48OIx4kztoXzuQrFDcaaGigRWyx1EP/5P7xzkGPI54p9t6YAU1D85k3XSOGaZUn6 S5DxZTPz7BZoXdKb74ZAiSl3N6xiIJDJHvXU1cHZyR1xUQHBBvZSJ86Fsjcti5JDCu 75vgGd90Wai6tFuYF/fJazVyYFkyXiV9hEeFhNV2jq4epqCVX6NV2I22hOFl3NdfcE n30/KysDCOg8vcen7PsQr2KcR9sKNC814b0us53HNDDQIsC73mQHGqhRHAqgrJqvbS SA9LE4fio7UlFXNqBN7E1kTyvLquid1/rztOGXWZMZBxqujjzx6hfIQeAIGBryiVb+ xPnIfk0l/GZKg== Message-ID: <3cdc6bd6-f0c4-410f-b2a2-8cc2b5d1c522@kernel.org> Date: Thu, 27 Nov 2025 10:46:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/sparse: Fix sparse_vmemmap_init_nid_early definition without CONFIG_SPARSEMEM To: Jinhui Guo , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, fvdl@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20251127092512.278-1-guojinhui.liam@bytedance.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <20251127092512.278-1-guojinhui.liam@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/27/25 10:25, Jinhui Guo wrote: > When CONFIG_SPARSEMEM is disabled, the macro > sparse_vmemmap_init_nid_early(_nid, _use) passes > two arguments, while the actual function accepts > only nid. Drop the extra argument _use. > > Fixes: d65917c42373 ("mm/sparse: allow for alternate vmemmap section init at boot") > Signed-off-by: Jinhui Guo > --- > include/linux/mmzone.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 7fb7331c5725..f6dd181a4821 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -2293,7 +2293,7 @@ void sparse_init(void); > #else > #define sparse_init() do {} while (0) > #define sparse_index_init(_sec, _nid) do {} while (0) > -#define sparse_vmemmap_init_nid_early(_nid, _use) do {} while (0) > +#define sparse_vmemmap_init_nid_early(_nid) do {} while (0) > #define sparse_vmemmap_init_nid_late(_nid) do {} while (0) > #define pfn_in_present_section pfn_valid > #define subsection_map_init(_pfn, _nr_pages) do {} while (0) That commit is from early 2025. So what are the symptoms we are fixing? I would have assumed a compile-time problem, but no built bot caught that? -- Cheers David