From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 349BF4071D2 for ; Mon, 27 Jul 2026 14:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785163168; cv=none; b=ikznmaBLXFWf847ObXoTSLZzmHiS/FpgiC45PtXJkQWZToevcruY+PDzreqCbRX1x94iXnbIgd4ugr49tdoRYxGlIP3R7C6og5wDuLLhs874fCft+BlOL1JS4H7+FKZpedtkyoTmjhff8ccod9BqwZvwfYMZ06Nry7GIrkwjsfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785163168; c=relaxed/simple; bh=Zxy16+x799ihBBr6MJe6NLfjS8UfI3VxhcWSkMvxeyM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zu6qB9BNCizEJxDZDDRSogZyEbD38Fi5N4bsK6RLNSLyr/lOXM2jrlcLkVk50Q6ql/KZ3tlsgo0vlR7c/ugqR4JG5taDxGAbkv7w92iBUkhYY3DXfFP8WyTok3cy/QSV3H49tBwk9TmnMzLDJxI2E/quCV94zIIbkpsNtE3NZTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cnxgraeP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IbmXqwfQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cnxgraeP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IbmXqwfQ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66RDllmI4065981 for ; Mon, 27 Jul 2026 14:39:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aNiNwU2QrjjQdW9slXjUnT/0JOvoYgEc5+oULzxO43Q=; b=cnxgraePk3sg5GSX Fy/C6BKFOQKwhwxJC4foprG58vTDKyc9wfn2Y9MCjt27ia7i6Ks1UCMmb9xdZAfS TUFMilyElQQ4nI7UygXGsk8EMO/0nQSiooHhKMJww1JnmQC8QIvVr7F8v2YtCFnC V3SaMlMnE4FC0VlsPbKsz92eEHnJX9Gv9Vgx8z+AYAL9FZUExb4vOGhQplJMTNKp Mdno9Tu63Vd9XvffFKdtqGCW1p3hZWBexODpxKYIY3/rxmekEyfVMh3bxmXGG25Y KZCOfEetABf2Wk5aNHCzoFRvtx+kC9Tvup0A1d5yWA8jgFDCOhche4OJuj+YSZoY 436Omw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fngysux80-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Jul 2026 14:39:26 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c20762d21so30213911cf.0 for ; Mon, 27 Jul 2026 07:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785163165; x=1785767965; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aNiNwU2QrjjQdW9slXjUnT/0JOvoYgEc5+oULzxO43Q=; b=IbmXqwfQYs8fbu+s7NaIwns76EqxbIYIOrizOCQS2i58/tvE9S6YUWjb3Db4r8spV3 YW5togUKNIgBB2zuT1Q1OyIFIvsTUSsjWFTbvugQz+gBVq/8BmD/VNS+Bflv1knCiuOb eLCt9c73+S00lS/G4J0nZdyPig58Y77g4jd1GCWJZkcZcHl60T0jMOdecz/qOVPPLSyd eIxPpOKUNpck9/vEwxpyxrs3pQQW6YesmsjvHZGlXaTKDYPKRo+LAPAA0Yq51k4QTf5z 46R2qsu6gX8My24LR4QzjYdZTqZU+CawpWzV56EHl8fF5CC3HUALi6cyZfz5anJLWVaA eqvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785163165; x=1785767965; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aNiNwU2QrjjQdW9slXjUnT/0JOvoYgEc5+oULzxO43Q=; b=STT2sKBgIdBBAs1sRucrItRJwnx8h+3zN47D58HsUNJVys8ncijNTXXXIfDwmZMN4k sGO0F78SqLF+zXdh4Ht2VBxFq7MuQt7QHSPK0hGNXA39yUaN8vLpzpIswQhNRwC8b2B0 zDaXhrD61fvRZfRVzIRfEOrTyG3i2zEhX9sfmm4LTglX0BYLdiJhtkDkZuKIEzdRQrXD dVZUkjKhGp5O8rDLm01cNb1jKzSg/uyGr80fB1lNIVRlskHiYzqkA3U96u81aVgy249C 3lk3PixbuxuFM2jo0In4MF+KXaI4azdd2+IcI2TS/FNs+IuQWQVrysLBd3V42yNk+fDI iCYw== X-Forwarded-Encrypted: i=1; AHgh+RpoiGeF+FtXjdSOGdMlHE6XYfLZ/xrwQ3bJPFhUyslTliBxuLqkUIlesCrAqvuGGYVw16WFqKPuCPYA+lE=@vger.kernel.org X-Gm-Message-State: AOJu0YwI+d7HYWvB3/UYpHzUx7FlcIs665Aokm9Ps8Gl5PjsI8NHW/Uw iwUqaIXfoA9YHVrH8LjEMtJy6LLK1+FutoRMyVF+6Rl++TBf9jhgs43II949cOa5HYqyscaW0UO 6pIys3XdGpsNywjtojbjKQJbqlkpUhLMk2uR1QNT7Ngcc+HtPBQ46bUEJc9yGlbChkQ4= X-Gm-Gg: AR+sD10WfHpoFXz/JdnkOTpHSP89CUJU7cL4/lMLf49DDNMWX9Myh2N+6sZN/s6mfJY MMI9PHXGaZe3tj2+lsaB48Ftdjjg9uv9otQqmO/q8nJXPCSUYtR2drYnGxwokniNKdAp/Y9WMGL lD/5HUzE1DiWottW+2zpdOZKJF6NF/4wbRoaUarE1/cQh39hE1ELwXxzLC01L0mUDlrxw8HWuxc ciFu5MttvjEqe3vq+xi7h/UUvD3isRhl6eMDFmYYNeVw0TYV6ZzocUVBbXxFUwOE5e1h1vrUssR WqF2JWrX/ZIy77oWyNLyXZiQs2i4CkpUPZqj941wcdfwD/VbZ+Ox/2LiZftsil9nD/8eT610Vj5 Q+eQsLimRXZXAlrT1MaMG/uEpNXMkNsmhzsKBnVEAXKE5ZA== X-Received: by 2002:ac8:7d86:0:b0:51c:1811:6eaf with SMTP id d75a77b69052e-529a8732f6fmr90542231cf.65.1785163165404; Mon, 27 Jul 2026 07:39:25 -0700 (PDT) X-Received: by 2002:ac8:7d86:0:b0:51c:1811:6eaf with SMTP id d75a77b69052e-529a8732f6fmr90541801cf.65.1785163164950; Mon, 27 Jul 2026 07:39:24 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85c6e9a2sm51480708f8f.35.2026.07.27.07.39.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 07:39:24 -0700 (PDT) Message-ID: <3ce0266a-64b2-404c-a904-25b6991f380f@oss.qualcomm.com> Date: Mon, 27 Jul 2026 16:39:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] thermal/drivers/imx: Disable clock on runtime resume failure To: Can Peng , rafael@kernel.org, daniel.lezcano@kernel.org Cc: rui.zhang@intel.com, lukasz.luba@arm.com, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260722084909.463437-1-pengcan@kylinos.cn> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260722084909.463437-1-pengcan@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDEzOCBTYWx0ZWRfXwcl9LFkAcM4y e/A1vY1utc3oCAURBtWHawFCfWI7MxKc4nmtYI7ccOg7IlLk80K+oX5qPmu1yHA6jb+SmhHdJ/K DZLnpCmc2hqbqRwdTNfnheEccmsfbZBx7lfywDRV4mxl51+dKFhjDgIbp5YiWbERdK1XmdXUbtE D4NoTY2L3I7ChdJFXsuVn3zHcmZOX8XWaoRUB9SlsBF0VLWw/G1VKVJF71rnNFh5YJdvffr6Rg2 /Ouj0slBDweOWGTQBSKeBusLDlILMTbZUN2p9KO3vq6W+SVegD2OVEC+as0y/W6QD5LHGkwryJf +7BB2tD9Fn1IJYdxNJLPRdMppkjXtzmkbikqrUCy3/1BvpfPXRibZaTKA3pLWIrKnKb0ib2E15l OJKc6a5m6t3TrXqwmcYrwZdfrO4SMTeZwYPBjuWMRgHp11FlXXNaE/0ugOgnUHM8aLiftVs6fie Ofq0zbURHctNkHzL7EQ== X-Proofpoint-GUID: eAKkR85SR-62p_fN4CKNNdAXvcfXu32d X-Authority-Analysis: v=2.4 cv=DNG/JSNb c=1 sm=1 tr=0 ts=6a676d9e cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=uw/3876vWhRnNVL35W6mqQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=mjVe68GCGcCyfEWORksA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDEzOCBTYWx0ZWRfX9INw+yk3JcR6 wB2fhUMj+KOKLjvio6rXXLVXc8NdyobDHC5kE5U2sUohCXRq3PwV6Tzm1dHM3NPmaBxBiVDSyV5 TxKSUjFtIOJ+dX8pR8tRs63aLgTAufc= X-Proofpoint-ORIG-GUID: eAKkR85SR-62p_fN4CKNNdAXvcfXu32d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_04,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270138 On 7/22/26 10:49, Can Peng wrote: > imx_thermal_runtime_resume() enables the thermal clock before > powering up the sensor and enabling measurements. > > If either regmap_write() fails, the function returns with the clock > still enabled. This leaves the clock enable count unbalanced after a > failed runtime resume. > > Disable the clock on those failure paths before returning the error. > > Fixes: 4cf2ddf16e17 ("thermal/drivers/imx: Implement runtime PM support") > Cc: stable@vger.kernel.org > Signed-off-by: Can Peng > --- Applied, thanks