From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <jacek.anaszewski@gmail.com>, <robh@kernel.org>,
<marek.behun@nic.cz>, <devicetree@vger.kernel.org>,
<linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver
Date: Tue, 11 Aug 2020 17:16:36 -0500 [thread overview]
Message-ID: <3ce38a31-a4f0-4cd7-ad09-6bdad27e6756@ti.com> (raw)
In-Reply-To: <20200811220109.GA9105@amd>
Pavel
On 8/11/20 5:01 PM, Pavel Machek wrote:
> Hi!
>
>>> Actually... This is quite impressive ammount of code to
>>> zero-initialize few registers. Could the regmap be told to set the
>>> range to zero, or use loops to reduce ammount of code?
>> I am not aware of any regmap calls that will set a range of registers to a
>> certain value.
>>
>> Well it depends on where we want to create the default cache values.
>>
>> Either we run through a for..loop during driver probe and delay device start
>> up or we keep the simple arrays and increase the driver total size.
> for loop will be better.
>
> Plus, REGCACHE_RBTREE is very likely overkill.
Well if I eliminate the reg_cache then I can eliminate the defaults too.
Dan
> Best regards,
>
> Pavel
next prev parent reply other threads:[~2020-08-11 22:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 15:31 [PATCH v32 0/6] Multicolor Framework v32 Dan Murphy
2020-07-22 15:31 ` [PATCH v32 1/6] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-07-28 13:39 ` Dan Murphy
2020-08-04 19:55 ` Dan Murphy
2020-08-07 13:42 ` Dan Murphy
2020-08-11 10:32 ` Pavel Machek
2020-08-11 10:20 ` Pavel Machek
2020-08-11 17:07 ` Dan Murphy
2020-07-22 15:31 ` [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-08-11 10:29 ` Pavel Machek
2020-08-11 10:31 ` Pavel Machek
2020-08-11 10:54 ` Pavel Machek
2020-08-11 17:27 ` Dan Murphy
2020-08-11 22:01 ` Pavel Machek
2020-08-11 22:16 ` Dan Murphy [this message]
2020-08-11 22:26 ` Pavel Machek
2020-08-12 16:00 ` Dan Murphy
2020-07-22 15:31 ` [PATCH v32 3/6] ARM: defconfig: u8500: Add LP55XX_COMMON config flag Dan Murphy
2020-07-28 13:38 ` Dan Murphy
2020-08-03 23:14 ` Linus Walleij
2020-07-22 15:31 ` [PATCH v32 4/6] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-07-22 15:31 ` [PATCH v32 5/6] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-07-22 15:31 ` [PATCH v32 6/6] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ce38a31-a4f0-4cd7-ad09-6bdad27e6756@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®