From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989AbdLSUSs (ORCPT ); Tue, 19 Dec 2017 15:18:48 -0500 Received: from mout.web.de ([217.72.192.78]:59218 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbdLSUSn (ORCPT ); Tue, 19 Dec 2017 15:18:43 -0500 To: platform-driver-x86@vger.kernel.org, Andy Shevchenko , Darren Hart , =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] platform/x86/dell-smo8800: Delete an error message for a failed memory allocation in smo8800_add() Message-ID: <3ce85d6b-6b25-2988-960b-84fa0b7a8c61@users.sourceforge.net> Date: Tue, 19 Dec 2017 21:18:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ailgCXo9EkRV/F8B35fGiW7aQsZZyIHhgMdXt76p/m+FGFqyOo5 4WaX+7UihGyDtYrFTrLXcnFoAhYtzrVKXy/oG/wM8ulMvfLTqWM0wYM0dfsTFofXwMUqLFD 350q94OhaXDb0UAWJzlA4P0HjDtVZ7pcxsnWPqPIMJ+4UfVWE2Z9WF65BslK993ICCa6hUu vdmFjfWmbnDpzou0gvNiA== X-UI-Out-Filterresults: notjunk:1;V01:K0:vbd1n9tSJf4=:Thv91esM3A3i2G5RwpLoym 6rB8euIMJIn6+nsk69dp1ptGGqkTHe7WHZsE1CjSEEjvT2RdKCblx1B8vJAHcuZgbLoR+/zL7 gvpGPZswntNnLFprOYDO26W/RjHVVHLY9aoOoGMcsmDMyAtTHjgZpb+6iT4xmIE5TulvPH5RP ocmNOFyBzQRrZMngil6+gONZIREMkxgrjjByOLu2/Nwl66tv9fYALBH0+z1vnZgT0zYBMD7ua dSz0kEkLlaAmiJhNHotw6ZxL0GnnELeBao594JO1t5WhRiLasNW9v3gx6XYhuKRFJDdXXIlQL WJYgaeTtck9SSyuuD/R7becmjLgviCha46k6laf7AUIiQmIZzs1Ae5+YTZweDaiTeS5my422I 23+pSNHEBT96amw/6Pl4hulDBPblg+mWfCKqdkGwqY5H6wYMdr9WdKgST5FNLJdHECvUNU9g6 RWmW5+rfREcY0sE/5RDKxXomI46YXFXfARtL354ibD5a6/DymR8M3Z6jeThhBB+FOVF3BO6yU xGt4XnaR3krhgQQvWEj+2+Tova7jxiezwmtsRqOQnuHtdynupnzKJP6wZCtECLL80tBJn2E8e ZKtrNojst3jk5UTgyF41CogL+EiJvO7CUiTjMobLIxJsJCQ3BbJ8Lb1/DQd5kJATdF2WB/DC3 sfPNCh66nZdaMjpu0eWGDBHcd5aO7v9GQo+FRBETobvmCGCuIJ3o/Fbo+znFjdr0i/G0Az+7p fV7Ls76orczFAqT8j64S3tRhY7ujA8D36yq1HElsCkbXsyU1+bmknu3R9Mwy2++8kf8yZe1ze qhZMVrGiNbXZzosvYyE9qd04MpmLXoTN6g/7seePqfvbWlqADA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 19 Dec 2017 21:12:10 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/platform/x86/dell-smo8800.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/x86/dell-smo8800.c b/drivers/platform/x86/dell-smo8800.c index 1d87237bc731..9590d5e7c5ca 100644 --- a/drivers/platform/x86/dell-smo8800.c +++ b/drivers/platform/x86/dell-smo8800.c @@ -150,10 +150,8 @@ static int smo8800_add(struct acpi_device *device) struct smo8800_device *smo8800; smo8800 = devm_kzalloc(&device->dev, sizeof(*smo8800), GFP_KERNEL); - if (!smo8800) { - dev_err(&device->dev, "failed to allocate device data\n"); + if (!smo8800) return -ENOMEM; - } smo8800->dev = &device->dev; smo8800->miscdev.minor = MISC_DYNAMIC_MINOR; -- 2.15.1