From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751308AbdCPBpf (ORCPT ); Wed, 15 Mar 2017 21:45:35 -0400 Received: from smtprelay0128.hostedemail.com ([216.40.44.128]:58391 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750909AbdCPBpe (ORCPT ); Wed, 15 Mar 2017 21:45:34 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:800:960:966:973:988:989:1260:1345:1359:1437:1534:1542:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3867:3871:4321:4385:4605:5007:6261:10004:10848:11026:11473:11658:11914:12438:12555:12679:12895:12986:14181:14394:14721:21080:30054,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: pet05_5ab328df00b3a X-Filterd-Recvd-Size: 3211 From: Joe Perches To: Andrew Morton , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org Subject: [PATCH 3/3] mm: page_alloc: Break up a long single-line printk Date: Wed, 15 Mar 2017 18:43:15 -0700 Message-Id: <3ceb85654e0cfe5168cc36f96a6e09822cf7139e.1489628459.git.joe@perches.com> X-Mailer: git-send-email 2.10.0.rc2.1.g053435c In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Blocked multiple line output is easier to read than an extremely long single line. Miscellanea: o Add "Node" prefix to each new line of the block Signed-off-by: Joe Perches --- mm/page_alloc.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6816bb167394..2d3c10734874 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4540,20 +4540,23 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask) " inactive_anon:%lukB" " active_file:%lukB" " inactive_file:%lukB" - " unevictable:%lukB", + " unevictable:%lukB" + "\n", pgdat->node_id, K(node_page_state(pgdat, NR_ACTIVE_ANON)), K(node_page_state(pgdat, NR_INACTIVE_ANON)), K(node_page_state(pgdat, NR_ACTIVE_FILE)), K(node_page_state(pgdat, NR_INACTIVE_FILE)), K(node_page_state(pgdat, NR_UNEVICTABLE))); - printk(KERN_CONT + printk("Node %d" " isolated(anon):%lukB" " isolated(file):%lukB" " mapped:%lukB" " dirty:%lukB" " writeback:%lukB" - " shmem:%lukB", + " shmem:%lukB" + "\n", + pgdat->node_id, K(node_page_state(pgdat, NR_ISOLATED_ANON)), K(node_page_state(pgdat, NR_ISOLATED_FILE)), K(node_page_state(pgdat, NR_FILE_MAPPED)), @@ -4561,20 +4564,23 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask) K(node_page_state(pgdat, NR_WRITEBACK)), K(node_page_state(pgdat, NR_SHMEM))); #ifdef CONFIG_TRANSPARENT_HUGEPAGE - printk(KERN_CONT + printk("Node %d" " shmem_thp: %lukB" " shmem_pmdmapped: %lukB" - " anon_thp: %lukB", + " anon_thp: %lukB" + "\n", + pgdat->node_id, K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR), K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) * HPAGE_PMD_NR), K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR)); #endif - printk(KERN_CONT + printk("Node %d" " writeback_tmp:%lukB" " unstable:%lukB" " all_unreclaimable? %s" "\n", + pgdat->node_id, K(node_page_state(pgdat, NR_WRITEBACK_TEMP)), K(node_page_state(pgdat, NR_UNSTABLE_NFS)), pgdat->kswapd_failures >= MAX_RECLAIM_RETRIES ? -- 2.10.0.rc2.1.g053435c