From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F181C43219 for ; Tue, 30 Apr 2019 20:53:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBC6720652 for ; Tue, 30 Apr 2019 20:53:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727230AbfD3UxE (ORCPT ); Tue, 30 Apr 2019 16:53:04 -0400 Received: from mleia.com ([178.79.152.223]:57188 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfD3UxC (ORCPT ); Tue, 30 Apr 2019 16:53:02 -0400 Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 6A35D4668DD; Tue, 30 Apr 2019 21:53:00 +0100 (BST) Subject: Re: [PATCH 41/41] drivers: tty: serial: lpc32xx_hs: fill mapsize and use it To: "Enrico Weigelt, metux IT consult" , linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, andrew@aj.id.au, andriy.shevchenko@linux.intel.com, macro@linux-mips.org, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-42-git-send-email-info@metux.net> From: Vladimir Zapolskiy Message-ID: <3cfc4396-b152-e9a6-bf29-a4c901ac90e6@mleia.com> Date: Tue, 30 Apr 2019 23:52:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1556369542-13247-42-git-send-email-info@metux.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20190430_215300_466850_76BEA83B X-CRM114-Status: UNSURE ( 6.73 ) X-CRM114-Notice: Please train this message. Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enrico, On 04/27/2019 03:52 PM, Enrico Weigelt, metux IT consult wrote: > Fill the struct uart_port->mapsize field and use it, insteaf of typo, s/insteaf/instead/ > hardcoded values in many places. This makes the code layout a bit > more consistent and easily allows using generic helpers for the > io memory handling. > > Candidates for such helpers could be eg. the request+ioremap and > iounmap+release combinations. > > Signed-off-by: Enrico Weigelt Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir