Re: [PATCH 2/4] dt-bindings: firmware: stratix10-svc: add fcs-config property

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/12/2025 12:35, hangsuan.wang@altera.com wrote:
> From: "Wang, Hang Suan" <hangsuan.wang@altera.com>
> 
> Altera SoC FPGA Crypto Service (fcs) provide hardware crypto features
> through mailbox. Fcs property has to be added to compliance with device
> tree schema fcs bindings and driver.

Last sentence is completely redundant. If you add new devices for some
"compliance" you do it wrong. We don't build hardware for "dt compliance"...

> 
> Signed-off-by: Wang, Hang Suan <hangsuan.wang@altera.com>
> ---
> ---
>  .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> index b42cfa78b28b..c105f8dc4b7d 100644
> --- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> @@ -62,6 +62,10 @@ properties:
>      $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
>      description: Optional child node for fpga manager to perform fabric configuration.
>  
> +  fcs-config:
> +    $ref: /schemas/misc/intel,agilex5-soc-fcs-config.yaml
> +    description: Optional child node for fcs Fpga Crypto Service (fcs) to perform SoC Crypto Engine.

You need to wrap according to Linux coding style. Anyway, above schema
is NAKed so is this child.

> +
>  required:
>    - compatible
>    - method


Best regards,
Krzysztof