From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A04347C6 for ; Mon, 29 Dec 2025 16:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767026501; cv=none; b=IsE2uf8TE1nNa9vSfFZPXxp32dT9mFZZFpDGTYFzP/jzHMeEOL07YcXBdhdz4USBkrAzJVxSb6qY/vPGZOz9TVYt5LBRYsFPMxTHu/wdB7S7Zc62pOoRbuFgqy6FcG5b9N/Z2h7KgxPwZUn5vJIOJMINGd0/wcNXPHbRqLwpjdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767026501; c=relaxed/simple; bh=erNds734pLhyo2IuhkHeEy9WhoqgmQRoacL6Efme4OY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jLKWYG04FvZBhklR9eqokuduygYY1iVvpJZaaZIR9gSICb7Xv7+Vi+QoTZfiqW2+Zd+2Gh0AHFhNftk5MwQn4WVoxxMzA+aIpHNoZRoa6kuqNKNlbdIh9E3bs5a0Ki4C+CADHq98bf5KZ4neNMaFmLvZ80L0S0//HOTwQtHA6BM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SsKGSgaa; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FjMZMMd5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SsKGSgaa"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FjMZMMd5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767026496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bYn3jQE6vngRVH3G1pRtRLPP2F+9+MHMDtsX3KrLli4=; b=SsKGSgaa/K5bOINuri51fFsCQY6yJxdqTYS7cSrmiAgMnDjpZQEonfgUQYciQbZdHI1Dpm bCDVAy2/rVLcgTEkGjtcRh5r0Zma904i6zrUiVOo/XY8gEMCRg8wdwPsoteV4nQO5eCmPu F2rNEEOTQoXx5qRJ+pEbdV08EfO3e2k= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-vCvyewUEPzylezNvQAo2tg-1; Mon, 29 Dec 2025 11:41:34 -0500 X-MC-Unique: vCvyewUEPzylezNvQAo2tg-1 X-Mimecast-MFC-AGG-ID: vCvyewUEPzylezNvQAo2tg_1767026493 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4779edba8f3so68217635e9.3 for ; Mon, 29 Dec 2025 08:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767026493; x=1767631293; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bYn3jQE6vngRVH3G1pRtRLPP2F+9+MHMDtsX3KrLli4=; b=FjMZMMd5iTEhMU3C5+WLeTIyEByrBOm8dQTYElFSZTcIxuRSVL0SDZD8L/BAC8SOWf 09KTg7ULT373+1ToCoBExOuMvPLGZ7k/lJdN7tWSKSjVo0DmApWtkps+84LHDFVr0rBD 2bUrr3h/r/J1mf4m0MtII3ZEplsIo1hnBaAx8He+ZWYS7wXihL98TG4PiSoz83Lx9SjY re/cnDv9dlasQ4ZNxCzZexJ4S14/kPn8ek6iQNmBSagjCYPP+9WU4WvRq4mELgnUy3PR Sv/evu4MdA1cDzon0+3Z8G51yKYoSlGU4GJnPqsA5CBmVKc3mUYTumt+CgEy20GvenIw 4GiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767026493; x=1767631293; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bYn3jQE6vngRVH3G1pRtRLPP2F+9+MHMDtsX3KrLli4=; b=IwoXq7XE56NuSQUoeN2HYV/oRtWkD/CKq5htv+07ws4+g2/KmaeRmSDoX9u5w/w+7Z Qq/CZopqLnYVdSumLUIplM+i4+7fYNezFf/wMV/zjrL2UqCcaBpjs1uy+TnB2p10U5RT +qA0eEheT10DM8JRdCX5PP9ujmcFjW7TIaqF4KnfS4nifFgU3yfQNyr3kuCnXroVeJra u8ViyYpT5rcCR51EhQVzciWhDdfvtLUnUQulkmxoe3zZZrjnLQmE4W51fIMPlj9r/8p+ aI+oM+x0fKyf7opnTSXkNVfJiZRgUJAIm47cR7ombg9k2qTdEfjPwZYpuu4+KUKmKxrC 3rlQ== X-Gm-Message-State: AOJu0YxIjgOTzYIeKHTEbai9MxowW9Y6skuxDHAjQS59kGiPJuCjNZM1 LyYTSP7yS7f+DaGB+z3n7jjg256tsc8Lk6IFPUR5tI568fxpGS/P0IXn7ghX0n/YWt17LSbZ6Zk OLCp0ljeLpQF5P34au4o6FND/JyuFkzZhawR+ock/J1FcHr6JbCioe7/JpurfJaypPw== X-Gm-Gg: AY/fxX4u47TK7s6F456TOQB+czf/aX5xYaoaZ/IoQsArFzp3ZAJ2UcHAC4E3aD/Rt9J 14K1YebTD/1IcTaeaY1/23sZW3eJw8dbJZnd/FzT3+QlSHTOAm2XKtHwggH5YDDfq7JCTdIEKF7 xv9oYUVTmr3g027zEfrrI4QOov6BukKFsMZKoTUbYRtShyX+tdQfgPRedq0IzwSaT3fbZap6kuu 2W+2O0YOwOvHIKWvTwVqLOsTdGWdzhEdfNILdrM7jaOnGBGYaqZbAWC5ZxURiIotHp/ySwYz9r9 GwtujIvJ13PLeJkKYX03p35QgTEaoSgRlLa3PvayKJu6+X4tS1fGmGnPITakXFTPKBfWXZi8DU4 ahseOJVBGb3XOww== X-Received: by 2002:a05:600c:8209:b0:475:de12:d3b5 with SMTP id 5b1f17b1804b1-47d2150caafmr326896095e9.34.1767026492801; Mon, 29 Dec 2025 08:41:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmuh1Z3nwF0lpjmqjZlKGu0DpKv6n8Wur+/t/yAgN0dAj5yrCvTM2a7xdPIziXO9K76J0VSQ== X-Received: by 2002:a05:600c:8209:b0:475:de12:d3b5 with SMTP id 5b1f17b1804b1-47d2150caafmr326895855e9.34.1767026492425; Mon, 29 Dec 2025 08:41:32 -0800 (PST) Received: from [192.168.88.32] ([169.155.232.231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b0d5asm605461255e9.13.2025.12.29.08.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 08:41:31 -0800 (PST) Message-ID: <3d00ff0b-58b6-484e-b5cf-202ba839acd3@redhat.com> Date: Mon, 29 Dec 2025 17:41:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuWkje+8mltQQVRDSCB2MSBuZXQtbmV4dCAwMC8xNV0gbmJs?= =?UTF-8?Q?_driver_for_Nebulamatrix_NICs?= To: Illusion Wang , Dimon , Alvin , Sam , netdev Cc: open list References: <20251223035113.31122-1-illusion.wang@nebula-matrix.com> <19aba6f7-acaf-45cb-985c-54be21592bdc.illusion.wang@nebula-matrix.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <19aba6f7-acaf-45cb-985c-54be21592bdc.illusion.wang@nebula-matrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/29/25 2:47 AM, Illusion Wang wrote: > 发件人：Paolo Abeni > 发送时间：2025年12月23日(周二) 15:08 > 收件人：Illusion Wang; Dimon; Alvin; Sam; netdev > 抄　送：open list > 主　题：Re: [PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs > > > On 12/23/25 4:50 AM, illusion.wang wrote: >> The patch series add the nbl driver, which will support the nebula-matrix 18100 and 18110 series >> of network cards. >> This submission is the first phase. which includes the PF-based and VF-based Ethernet transmit >> and receive functionality. Once this is merged. will submit addition patches to implement support >> for other features. such as ethtool support, debugfs support and etc. >> Our Driver architecture  supports Kernel Mode and Coexistence Mode(kernel and dpdk) > > Not a real review, but this series has several basic issues: > > - each patch should compile and build without warnings on all arches > - don't use inline in c code > - avoid using 'module_params' > - the preferred line width is still 80 chars >>>>>> > > Thanks for your quick reply! > However, I noticed that at > https://github.com/torvalds/linux/commit/bdc48fa11e46f867ea4d75fa59ee87a7f48be144, > And the checkpatch tool checks for a line width of 100 columns. If we make the change to 80 characters, it might reduce readability. > Could our driver set the limit to 100 columns instead? Please use consistent top quoting in your next replies. This one is quite unreadable. Networking still uses 80 column boundaries: please adapt your code accordingly. Thanks, Paolo