Re: [PATCH] arm64/mm: Use CONT_PMD_SHIFT for ARM64_MEMSTART_SHIFT

[Gavin Shan <gshan@redhat.com>]

On 6/14/21 7:42 PM, Anshuman Khandual wrote:
> ARM64_MEMSTART_SIZE needs to be aligned with CONT_PMD_SIZE on 16K page size
> config. Hence just directly use CONT_PMD_SHIFT.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> This applies on v5.13-rc6.
> 
>   arch/arm64/include/asm/kernel-pgtable.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Yes, It makes the code a bit more understandable.

Reviewed-by: Gavin Shan <gshan@redhat.com>

> diff --git a/arch/arm64/include/asm/kernel-pgtable.h b/arch/arm64/include/asm/kernel-pgtable.h
> index 88b8d681ad91..a848da2b4d90 100644
> --- a/arch/arm64/include/asm/kernel-pgtable.h
> +++ b/arch/arm64/include/asm/kernel-pgtable.h
> @@ -125,7 +125,7 @@
>   #if defined(CONFIG_ARM64_4K_PAGES)
>   #define ARM64_MEMSTART_SHIFT		PUD_SHIFT
>   #elif defined(CONFIG_ARM64_16K_PAGES)
> -#define ARM64_MEMSTART_SHIFT		(PMD_SHIFT + 5)
> +#define ARM64_MEMSTART_SHIFT		CONT_PMD_SHIFT
>   #else
>   #define ARM64_MEMSTART_SHIFT		PMD_SHIFT
>   #endif
>