From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbdE2XIu (ORCPT ); Mon, 29 May 2017 19:08:50 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34864 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbdE2XIs (ORCPT ); Mon, 29 May 2017 19:08:48 -0400 Subject: Re: [PATCH] scsi: lpfc: make a couple of functions static To: Colin King , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org References: <20170518093524.13549-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: James Smart Message-ID: <3d1696a8-0f7b-20aa-b242-839b91cc7068@broadcom.com> Date: Mon, 29 May 2017 16:08:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170518093524.13549-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch is fine. Signed-off-by: James Smart -- james On 5/18/2017 2:35 AM, Colin King wrote: > From: Colin Ian King > > functions lpfc_nvmet_cleanup_io_context and lpfc_nvmet_setup_io_context > can be made static as they do not need to be in global scope. > > Cleans up sparse warnings: > "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared. > Should it be static?" > "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared. > Should it be static?" > > Signed-off-by: Colin Ian King >