From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD9B7303C93 for ; Mon, 24 Nov 2025 13:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763989657; cv=none; b=ZzzcrnYpzOEc6mbCmnz2THv6Nv7U+xU7oIB81QwMfDHTffC2O4F5+blx6lH00lGq/F8c5Ck3OrHQEouH93pz2Ss9AQPA52AHqc5+agpr9S9po4CsthUGjiWjhQyGMmIc3E/KfDm9nCSHJJ7lAc49aPOqx3nUbizhPoqUMqFzyYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763989657; c=relaxed/simple; bh=0Glmjqomcfr+teooEmAf7u9Ao6AQVwqhuxQMy1kpDiE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jDeNUUpg5Fk95CDlVtV2xthbffo5KM6ZfYHjfpDR5Ae/nWX8JUihoENAyPoXx6c9s82sMJxQ3uGLXdfjwTCEv+IlMj2PxEQ6ulH3d1WgTJ7o2OOyquetafbQDAlzLSnw7ePkc/SQSiOZI/G3QgKznW9EJZUDeTibqj6hFI8rhYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LChTinB0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HcNeBnRO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LChTinB0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HcNeBnRO" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AO8RFWY1946548 for ; Mon, 24 Nov 2025 13:07:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WsZi9qGDQC7YaNJ5xGSEkcWOjZ6iCniWpRgPXtNFW+Q=; b=LChTinB0jd8rFVo9 2wsTtwNHOgT7xuMQmeD1LrNEUCctTlmA8d/on7rzdVf57jbZLn4rKTOzjpx1DAFL eASMt6ZZWTqPxVDI4tje2JePGepQH8u+FDA2s3mJxlxHszI242eg3Xdr9LGIflKJ Cfgc/EoYc4ChDnjjTARePhL1t6FuGFXsWnK2j1Fj9f/45d27H9NOldAzsq2HNzO8 Qxu6NsHtuaFXQiVSaWVZUwputVRloIqO1l03mnUGe34mYGgitT9Z8Yu3R0iHC59A o/BIRkbMOtZPHQvrkE5aKCaEkXPNQj9fT2hxYacS3ycZiiESGUfkGk8ZPOcoc/Ir UQ2Apw== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ama09a22w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Nov 2025 13:07:34 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-559ef1b1daaso332589e0c.1 for ; Mon, 24 Nov 2025 05:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763989654; x=1764594454; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WsZi9qGDQC7YaNJ5xGSEkcWOjZ6iCniWpRgPXtNFW+Q=; b=HcNeBnROSEyEo74aB1wtF8G+rQVhPkJT6rXAu8Yhz8pR4fsMFpQelL1oUGXYkFyZ5Z XDOi1PzsiLS2cPkHIfOpe5esy2ci/GGtzE47feW5UL3iz8GvmhtRhj/UpNKLQQNxDAIK cJZPcuTPz7uEZVwty1NcU+4dxQkREBbyAffPI2Qb8QsXQ0Gptxo/e4ADVaetSwZAJWsi 1JUVKeS0CDDNlxBVdG5o+p3aD8kYn1eIwcmlhIu+dFAY3BcpPwi5GDCtrvWO0UojriXG PBW0WU6LhCONo/nqmv/7NNURZrNm+1PrWTNBpi09IwAWNmcK4Vd5pEx+JjSg//so2TPx SVOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763989654; x=1764594454; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WsZi9qGDQC7YaNJ5xGSEkcWOjZ6iCniWpRgPXtNFW+Q=; b=dZIG1+50WnqB0Iw7gTGrRd1i1qaVstNtPjSVNxrxb52uiOkqy7sKlcuUvhvZnV/aIR RvGw1DmkMriBlkEhfTnvxrWax6Dma5cQSt849nuAJscSVj6TzKd89fMSV2wcu22IUH89 MTi1qYE9YzjPwT8aYlL6EQL8t8cqat573iQku7ctzjnmolsbcv16CWv/7ZpqJ7qtQ8/E 6ja2+WHwCOVp6K4kz7KpqTOk/No6+IbXtONutMxGaeqgjJENA5+EGyor/8m4Y8f8wbTa JzEvFcjqMUSb9YpdyC+I+kkcIm6w3BwW02KSYIEVZUjNPjZcfC2Bcdj5wS/8yxWNz67L CuSw== X-Forwarded-Encrypted: i=1; AJvYcCVbn5kXfr0W9Xe1mR6by6NOaHtkYqLPps0bT0j4fCBNM/sjRadcN6Iq77L6GBjoSBBJUzNG9qPePZsS9OM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0Jg/5RVFJBZb09nG5zqFeV2BC2VG6mb1zxV1fCIKiBqXyebfb D8ZaPVgj06Cm59nwTOArmmOimC9f9MQAVEwGs4yUZ37rp1M4o4gHL+Ig+zD4S9ODLEitYGd7eIr LJzEJ+P3bD4o8hhyEtS8o85BYABCPTV4eV+C+qxqBSf4Zh9FNRWcSjqHL6KBlxLNFJBM= X-Gm-Gg: ASbGncuRhAo+yGzb42N3mA7STxqjlf8XdbbgGUCeCtGnYu0g7Zw8RvYBisbrhpdo7Jp Zct7TTWAfgGU/0v5/C22I9ly3imsyPyMnq4q+MBJlACx2NZF/I0yjqoOjFawl1V5BadT57nPGC/ gxL/SOBl/rqeNMOgMIxfCyTEYXXubZu4JPvNiQIvIY4vAZrAGj5ENFSd2dpQIuPZfozPYJyiFGE gcAfyZ+pWQ1heBlE2bVIIGk9WQ/JnFgW7BJGUpHXT3dpHbE6xj6Wzm/CNlG+veEitDOot5vae/z RGlf6xPRIQKpKAZ9pA8Z63lebFVGpfyJuJaq9unF9hJMEsCt+BdO0Kh33REwTChd6EiGM1QuV0z tAQ6KdPzbSe7bf0ec7PnLmGVO9+rLzCJhZnqhZOW07TOKvnj73skv/JX9jI9ntmMo8rg= X-Received: by 2002:a05:6102:5487:b0:5dd:c3ec:b7c with SMTP id ada2fe7eead31-5e1ddcc3b29mr1736168137.0.1763989653783; Mon, 24 Nov 2025 05:07:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IHHHzwPnAtxx8b34+t8asUge+jdf6cN5myr0cVk8y833MZohwdZmdf8rJTGC1s8GlYGNHNH1Q== X-Received: by 2002:a05:6102:5487:b0:5dd:c3ec:b7c with SMTP id ada2fe7eead31-5e1ddcc3b29mr1736132137.0.1763989653330; Mon, 24 Nov 2025 05:07:33 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654d7cafdsm1264069966b.30.2025.11.24.05.07.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 05:07:32 -0800 (PST) Message-ID: <3d19b567-c6fc-4fa6-a224-d8b7e3995607@oss.qualcomm.com> Date: Mon, 24 Nov 2025 14:07:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] soc: qcom: smem: fix qcom_smem_is_available and check if __smem is valid To: Christian Marangi , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dan Carpenter References: <20251122185002.26524-1-ansuelsmth@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251122185002.26524-1-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 9_s0eAqMGN1ZQaTYfzpPGvrg8HbDvbQL X-Authority-Analysis: v=2.4 cv=PdHyRyhd c=1 sm=1 tr=0 ts=69245896 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=T0WpHGM8YF_DXorlBugA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI0MDExNSBTYWx0ZWRfXxu7lQyv7usSA lbXKfhOWZ1hqzGjMQub41CJy6PkSYpjmBnKRZiUsnm108DiroDzXHXyK4UbnGtDH6PmreyjYraE Ti28UnceQzNlw59MKQyf9gJTSs3jyckG34cTJylTCj/yIWeZUOV20gK3t/osYnqOYwpjh1mbhL4 6jlr6zDctWMiAd/zPW3GeNGP8RAnSXISHFuvX0s5dV+4VMiai2RbQy0MukLtose/WYsSo7QBEu5 YyQ/cl2D1nmcIn2ucd54WHYKLIOPLef6nCdJmCqxIvAiRrzHX2Inq6lValr+SI0VDS01q28atfl kqGXmH0LNM88fD1TloR4kVMHvERIzhHOzlDvp1Qp0WvICTSQLLv7J/NcRwNsjm1W48uyZM6bkTd Yn3nroYy7WTcuDnP/JOt3+UE6aaNTQ== X-Proofpoint-GUID: 9_s0eAqMGN1ZQaTYfzpPGvrg8HbDvbQL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-24_05,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511240115 On 11/22/25 7:49 PM, Christian Marangi wrote: > Commit 7a94d5f31b54 ("soc: qcom: smem: better track SMEM uninitialized > state") changed the usage of __smem and init now as an error pointer > instead of NULL. > > qcom_smem_is_available() wasn't updated to reflect this change and also > .qcom_smem_remove doesn't reset it on module exit. > > Update both entry to reflect new handling of __smem. > > Fixes: 7a94d5f31b54 ("soc: qcom: smem: better track SMEM uninitialized state") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/aSAnR3ECa04CoPqp@stanley.mountain/ > Signed-off-by: Christian Marangi > --- Reviewed-by: Konrad Dybcio Konrad