mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Archit Taneja <architt@codeaurora.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, a.hajda@samsung.com, airlied@linux.ie,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: make drm_bridge_funcs const
Date: Wed, 9 Aug 2017 18:06:02 +0530	[thread overview]
Message-ID: <3d207993-195d-cef8-1aac-c0534a525bf5@codeaurora.org> (raw)
In-Reply-To: <2177679.cxpq8VCtMS@avalon>



On 08/08/2017 09:33 PM, Laurent Pinchart wrote:
> Hi Bhumika,
> 
> Thank you for the patch.
> 
> On Tuesday 08 Aug 2017 21:24:10 Bhumika Goyal wrote:
>> Make these structures const as they are only stored in the funcs field
>> of drm_bridge structure, which is of type const.
>> Done using Coccinelle.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

queued to drm-misc-next

Thanks,
Archit

> 
>> ---
>>   drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  | 2 +-
>>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ee16635..58b4fb2
>> 100644
>> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> @@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge
>> *bridge) return ret;
>>   }
>>
>> -static struct drm_bridge_funcs adv7511_bridge_funcs = {
>> +static const struct drm_bridge_funcs adv7511_bridge_funcs = {
>>   	.enable = adv7511_bridge_enable,
>>   	.disable = adv7511_bridge_disable,
>>   	.mode_set = adv7511_bridge_mode_set,
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01
>> 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> @@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge
>> *bridge) return drm_bridge_attach(bridge->encoder, dsi->panel_bridge,
>> bridge); }
>>
>> -static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
>> +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
>>   	.mode_set     = dw_mipi_dsi_bridge_mode_set,
>>   	.enable	      = dw_mipi_dsi_bridge_enable,
>>   	.post_disable = dw_mipi_dsi_bridge_post_disable,
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

      reply	other threads:[~2017-08-09 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 15:54 Bhumika Goyal
2017-08-08 16:03 ` Laurent Pinchart
2017-08-09 12:36   ` Archit Taneja [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d207993-195d-cef8-1aac-c0534a525bf5@codeaurora.org \
    --to=architt@codeaurora.org \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=bhumirks@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=julia.lawall@lip6.fr \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome