From: Krzysztof Kozlowski <krzk@kernel.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] w1: move slave uevent into w1_slave_device_type
Date: Tue, 8 Sep 2026 16:54:23 +0200 [thread overview]
Message-ID: <3d212544-d955-41c6-8589-6c3d6c6f7b75@kernel.org> (raw)
In-Reply-To: <20260820225430.1847356-2-dakr@kernel.org>
On 21/08/2026 00:54, Danilo Krummrich wrote:
> The bus-level w1_uevent() only ever added uevent variables (W1_FID,
> W1_SLAVE_ID) for slave devices.
I don't follow why only for slave. I see the w1_uevent() being part of
w1_master_driver and so on as well.
>
> Move the slave uevent logic into w1_slave_device_type.uevent where it
> naturally belongs and remove the bus-level uevent callback entirely.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> ---
> Compile-tested only, no hardware available.
>
> I think the dev_dbg() stuff wasn't really useful, so I dropped it.
> ---
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-08 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 22:54 [PATCH 1/3] w1: use match() callback instead of hardwiring dev->driver Danilo Krummrich
2026-08-20 22:54 ` [PATCH 2/3] w1: move slave uevent into w1_slave_device_type Danilo Krummrich
2026-09-08 14:54 ` Krzysztof Kozlowski [this message]
2026-09-08 19:12 ` Danilo Krummrich
2026-08-20 22:54 ` [PATCH 3/3] w1: stop using struct device template for master devices Danilo Krummrich
2026-09-08 14:49 ` [PATCH 1/3] w1: use match() callback instead of hardwiring dev->driver Krzysztof Kozlowski
2026-09-08 19:07 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d212544-d955-41c6-8589-6c3d6c6f7b75@kernel.org \
--to=krzk@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®