From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0DBC4332F for ; Mon, 11 Dec 2023 20:22:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345010AbjLKUWK (ORCPT ); Mon, 11 Dec 2023 15:22:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345032AbjLKUWE (ORCPT ); Mon, 11 Dec 2023 15:22:04 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2DD4D43 for ; Mon, 11 Dec 2023 12:21:47 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB20AC433C7; Mon, 11 Dec 2023 20:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702326107; bh=rBpsBQzFgdCR4uHw0YOyenL0nzKHxfcOgHqKnrLFUgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IsnscW4ZZ5eBgpkU295ZqeOTsNn9/RTDGLj7cdzfkE8r9Ykj9rjeLJWZOosb66RpM PcruomYoMTgkCOxzS7igzpPDXBSXxzbMKwDpyKmEn52XohKoXrPW+E4FaeTUTZn/vf TE3qxb83kDoO9+z3I2BE7RP6RRCqeG9Oazz/sB5uqVqZtClli7+l5e1u5pkoTigTEa V3YMc/Mulx67x28a+6szulTMl72N2/2hfHpb/71TBZBlG9ScNb/+3rwtjq8LhVoRYf 6jiEm7qGsyygnUZxQkZrZl+HWG8LWyMUyl4ymFPGxjkqmV0MNZZL8RX+rQMmNkD3Hl 7I/AKm1Q3PoWA== Date: Mon, 11 Dec 2023 20:21:38 +0000 From: Mark Brown To: John Hubbard Cc: David Hildenbrand , Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Peter Zijlstra Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Message-ID: <3d22f342-280f-4a44-87f4-8cca291cfce7@sirena.org.uk> References: <20231206103702.3873743-6-surenb@google.com> <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com> <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk> <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2t6rLyxDF+xX0gNK" Content-Disposition: inline In-Reply-To: <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com> X-Cookie: Better dead than mellow. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2t6rLyxDF+xX0gNK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 11, 2023 at 10:46:23AM -0800, John Hubbard wrote: > Or (4) Hack in little ifdef snippets, into the selftests, like we used > to do. Peter Zijlstra seems to be asking for this, if I understand his > (much) earlier comments about this. I can't help but think that if we're having to manually copy bits of the uapi headers (which are already separated out in the source) into another part of the same source tree in order to use them then there's room for improvement somewhere. TBH it also doesn't seem great to add additional variables that depend on the user's build environment, we already have enough build issues. It ought to be mostly tedious rather than hard but it's still a pain, especially given the issues we have getting kselftest fixes merged promptly. --2t6rLyxDF+xX0gNK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmV3b1IACgkQJNaLcl1U h9D6XQf9FJcaZ/aSuBGP4yhVAKDtuYM+O0Qsar4MJCFGlNRbAu/ep77u/lb6SiNm LU23BBBAiqPUIKnMW5exn+9u4d7eZg/jgUqktFGJQUooAZXP7tesJ2juToB11Von QMaHZ51yQWx/4vduSYWRr1jeH6bKVsC4iUQD8NAxCP7NgC5DqzoKkZUshRIJ1UPa m+TgJ2pDfv6sHcEeBnNvfGIUR7AtUlR+CyGsoRs+vv1EUYGuOmV46mf4w34U1FUc cSDhODvruTSYW8nNp0yvLcfzC+vgcC6N24IvLy06fYwhVWLsPx3dL089H+FYubVt 1ik547NSpFhk2Unxhvfsaj1pgPYtCA== =lcNl -----END PGP SIGNATURE----- --2t6rLyxDF+xX0gNK--