From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64BC63D5226 for ; Tue, 23 Jun 2026 11:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782215034; cv=none; b=M03Wto3hrhjOC62fHWlO2tGxmEZKN74+fppjKKW4F0vXXmi48uw3IRINKWfDt+2h1ZOALqvyODA9VXsP5XaRi4Lp1Y8V+5EVYeBq6oy3gALpymiLma70D10LbxhMK/0xVx/GH5lgzJOr3nChHN8EMMKlrBwTFNzKXWHXz0GjK2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782215034; c=relaxed/simple; bh=9xbBXXxIqa56/q5c7t8r4Zk0YJeO+xdElWD1RrJOVkw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=mcWd60Ex5Fj6tokvDaSJLo4wxi8ATKRVwxWV5W8ssclwBkkNgdZF8sjoSGEYHGyZUlucJVqG4OhHwFqRyN7hAs1BfKhnx5TkY8eQI4FmtBGshirXZb82xUJhOMhx3ORsR1ltceKmsM0f9YmhpxDK1DSu8SkXdODLSZGjbTqn/W0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F1BCHQUo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C1DsbQH3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F1BCHQUo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C1DsbQH3" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBXiEj3753513 for ; Tue, 23 Jun 2026 11:43:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rv1hQEHAcQj6Aub7u6JH8fJsjCG1ILRkkbQwG0SXkVE=; b=F1BCHQUoyV4k58s3 Np7B/Oal9LrUJem+nwByLUoBVzOCF6jeabLp8C+nNeCfW1mfpRTuzX2B+SP94OQr sRrk8NY3m2cK+dpryb4lB+Z7iOG39dI8Wo+MGNFqw+t9LiKlxVR5FBsUUzDfEoYj ltP9e0EaE2NCSihLArsXBcB2Z39hLqn1Pu1blBET1QTEpp2QOX0ZxLMW3dq2SIaj BioQDUa+/GoWgF7F1fLExLUx4lOS7x4bQdvMrxBytHoIHrZAwnsQBrU4lRspAYoe ksA4WVc2vH3F9SrVFXlOKb2x/Rp96JcNAbNARmcyYTCNYayFQz01czRiNbctitJa 58aj5g== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyp29gxxq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:43:52 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-517bdeceb54so2234501cf.2 for ; Tue, 23 Jun 2026 04:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782215032; x=1782819832; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=rv1hQEHAcQj6Aub7u6JH8fJsjCG1ILRkkbQwG0SXkVE=; b=C1DsbQH3JUQKnq2wsolJ8wh0Id31bcvcRBuoBl5a7fynwXEQJzgPXLyMhl68G+ieJH 2WqI9CnpkmZ791r21SgxzvotMDGq1pzqHLZJkiwUNsvoNFUMR7GJbIvyVsi9dgnCyjIl a3XFuIHxKxpvKNB5RnV6BOiOvrbyoJ3yO0O4XXGQ76ONjbZvYj9n9FVA+4sKv9uRmkXy lMddKucGIOtNiVXwIaiJZGZzveeCbkFDBWIeY//cBEM5EIFGhav6kknejgIWBRdCpHAT ad79RRzpmOnip9WJOBkwLXL9zpuilRt58CNmgJsUXY1btkSBRGnfjnzdcgCqLkqJjwmF r0zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782215032; x=1782819832; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rv1hQEHAcQj6Aub7u6JH8fJsjCG1ILRkkbQwG0SXkVE=; b=mq7wzakwrKMUbcreCe9CZB9zqk5ZGrNm+TbJHMPGDuDoSsGTC8rO+qcBLHvIRU9hGS TopAP8xsqMwgKdmpz8IYhhxoyP7N7XP+qumbaWYI9B14jHq6eaNYHOGh+0gldr2ZzmQM OQy6eOq4WgNOejuhh+CnMVDHHllWELLWt3u2XILmpY8ftM+ptYECcHTK1ZxOvk3WHtT5 0kEfhVWmxdp6ImTJtSuD35JDs/EppEysVx2iXUokgCjj9WE0vPgoCtfX5fWRNKzowue9 4xkITs9ttnS3krBrM0hlyrlFzzxKviLBffHYJfnEj8eAcEl1rzfqZPgAxLFVyJLGlDBV FSHw== X-Forwarded-Encrypted: i=1; AFNElJ/cbuC9yLdpo3ZXYIv7fv1qE1pGvAGqyiGNRtuqHVAeu5RZ4G1QnfOD2dSD/k9YWCRRD//n7F5foDUsugQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu3XXrsNkgSwng1zICuz3jYHoHcgHVGW5WChW12OUohiv/IzP3 hMtXmM4A+SJTxycuvQJxDYWYx3juRdA7IU3oIQEQu17R4LX9apBvmVmMcYHyr5iGqy0LlSkttpq OQbXyUxmOjEfE8uX2D5KxSc9KxuRoleIBf5rPYVWusmexWGkonWZxHtvnmaNmZz9dntg= X-Gm-Gg: AfdE7ckfX3AckmmYzu0BzTH0rPBA5+38RMIS8i5Y37zk0mzdVpF4eOHLQq5759Cz0UN BkF73wq1KUUQcsJtjKbQAKRVUgy+6pSe8+PIUUTdMAq5qlC5SZSojaNF31YLrecqv4BS+SgMvJT +fSKc7Fnw+hLjxikCgrwMNVKUDklH/J88TbUvayQEifuGUhdQwinaKLweMY+l2AZTtXZTV48rSP Mj0zTdsTi+3CTq9kmBv+tHASAIOqK9/aVmLxBhJsGn0BgJY3PqJn9yMdaOjyouR+gwMKtk07unp k6EUhhGQoI787GAx970ybZb/vFtFULxhfk7kR54KgwCK1s4ot4tfYwdnsDgmiAoYCxOGidD5hy/ Up2YNXSbtCpqDA1nj/vlk7RKuXhQd3ZFPT9w= X-Received: by 2002:ac8:7d91:0:b0:517:5e32:f3c2 with SMTP id d75a77b69052e-519febcfc63mr146663691cf.1.1782215031561; Tue, 23 Jun 2026 04:43:51 -0700 (PDT) X-Received: by 2002:ac8:7d91:0:b0:517:5e32:f3c2 with SMTP id d75a77b69052e-519febcfc63mr146663481cf.1.1782215031129; Tue, 23 Jun 2026 04:43:51 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977be4b9f6sm4376257a12.22.2026.06.23.04.43.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 04:43:49 -0700 (PDT) Message-ID: <3d24b1bc-baca-417a-8f60-a060cab5719a@oss.qualcomm.com> Date: Tue, 23 Jun 2026 13:43:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: eliza: Fix disp_cc_mdss_mdp_clk_src RCG stall on Eliza EVK To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260623112755.317180-2-krzysztof.kozlowski@oss.qualcomm.com> <6ad8d604-b04e-4f24-b616-980f0e18b4c5@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6ad8d604-b04e-4f24-b616-980f0e18b4c5@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=LdAMLDfi c=1 sm=1 tr=0 ts=6a3a7178 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=XyekhbN6Ike5yq1yYGIA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 0ZySJn52ZAFaVCJXjHUILyQ4TOmbVonO X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA5NiBTYWx0ZWRfX+6aBGHHBWcWV Plqj6+kG8UyQlSg6gRBYmwTZz5Z2kuHkcSNL4nhYQVq8e+9/kT38Cbnfvx/NEGf0I9ElHMDb3y5 iA7U7sTK9KK8Ty3QEJ/ClA9s8j4Ixhg= X-Proofpoint-ORIG-GUID: 0ZySJn52ZAFaVCJXjHUILyQ4TOmbVonO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA5NiBTYWx0ZWRfX6FHtW2mIC3sc 8jmymdkgZ3/nuzok/coiBqRUpVOzbaxrHhQSs9yNMhxNg7P3aE1LyNgK99gWiI/S+OHAKJuFiKs bZDuhl4NY7kmZye19AR5n2Chn5eK4qI4OW8bWexOgTeKVN01rjli014w8UUenQLjRh4uND7z2Yp Ifmm91VwYXIsM5R6dcED40xeZJ/kQg09+1hRgm76kfrtk8DeJBEpgxmgZmM6KlfHcFchfm66nSt LOE4EI9Moofh8tfhK2w5bPUa9iD11+WMWFwbqtD0pxJ+gncMkEVGFVXEeveLRqZRTl39Hl90Mup +4tTw26+DFSUPIW8QCdPuXE88fN0jLqKHfvJxt6kdBoQBrsFAgaaaizTE+BigRtDMxDD/S9pYBm z3EAKAAgbvO16EZNv8fRprLeEhDP91t66PCu3dQ6c/muMuZpZ4TdvHfyCzt/5eAOYs6XiXWZmAv 2/JQ3LEsM97iJ/un99w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230096 On 6/23/26 1:42 PM, Krzysztof Kozlowski wrote: > On 23/06/2026 13:38, Konrad Dybcio wrote: >> On 6/23/26 1:31 PM, Krzysztof Kozlowski wrote: >>> On 23/06/2026 13:27, Krzysztof Kozlowski wrote: >>>> Eliza EVK (eliza-cqs-evk.dts) does not have display enabled, however its >>>> Display Clock Controller is enabled and references parent clocks from >>>> DSI PHYs. Devices which in base DTSI do not have all required resources >>>> available (e.g. because they are simply disabled), should not be enabled >>>> in the first place. >>>> >>>> Having DISPCC enabled without DSI PHYs causes clock reparenting issues >>>> and warning on Eliza EVK: >>>> >>>> disp_cc_mdss_mdp_clk_src: rcg didn't update its configuration. >>>> WARNING: drivers/clk/qcom/clk-rcg2.c:136 at update_config+0xd4/0xe4, CPU#1: udevd/273 >>>> ... >>>> update_config (drivers/clk/qcom/clk-rcg2.c:136 (discriminator 2)) (P) >>>> clk_rcg2_shared_disable (drivers/clk/qcom/clk-rcg2.c:1471) >>>> clk_rcg2_shared_init (drivers/clk/qcom/clk-rcg2.c:1540) >>>> __clk_register (drivers/clk/clk.c:3959 drivers/clk/clk.c:4368) >>>> devm_clk_hw_register (drivers/clk/clk.c:4448 (discriminator 1) drivers/clk/clk.c:4672 (discriminator 1)) >>>> devm_clk_register_regmap (drivers/clk/qcom/clk-regmap.c:104) >>>> qcom_cc_really_probe (drivers/clk/qcom/common.c:418) >>>> qcom_cc_probe (drivers/clk/qcom/common.c:445) >>>> disp_cc_eliza_probe (dispcc-eliza.c:?) dispcc_eliza >>>> platform_probe (drivers/base/platform.c:1432) >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> --- >>>> arch/arm64/boot/dts/qcom/eliza-mtp.dts | 4 ++++ >>>> arch/arm64/boot/dts/qcom/eliza.dtsi | 1 + >>>> 2 files changed, 5 insertions(+) >>> >>> >>> I should call it RFC, because this feels like a band-aid and should be >>> fixed in clock drivers maybe. Eventually DISPCC should be enabled on >>> Eliza EVK for HDMI, but DSI PHY will stay disabled. >> >> I'd say all of that hardware should be kept enabled, if only to >> make sure that it's parked safely >> > > You mean enable DSI PHY, even though there is nothing attached? Yes, so that Linux can shut it off no matter its initial state (which may include "partially initialized" or "partially shut down") > My warning probably can be fixed same way as: > https://lore.kernel.org/all/20260622-sm8450-qol-v1-1-37e2ee8df9da@proton.me/ Quite possibly. IIRC Mike Tipton wasn't a huge fan of park-at-init to begin with. Konrad