From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44FD338CFFF for ; Fri, 13 Mar 2026 16:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773419970; cv=none; b=gQfbAUAw3+DtuNLKgIKA6nVcoL/vARacvd0YKSqxu3I6or6jXqGg9JcpcENPFf+D5i/LfumEWdKTYeDTkesxF++R+g/+kzOtko5p0NNDk9UGmu/9dNnbo/SdqtQod0p1g0208tIrXPNSZpL0jM0DwJBz3jY5KXK96ZH9zloWyXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773419970; c=relaxed/simple; bh=Qj7u7fKzT27EaALLTcCusFhJ7ATg3tivF3VhphoT12w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OdEId/NhgV/9ymzgXjNcNzwofsxoo6mQjKEy0CsV/Qixk8PXqF5BO9JXkYoy09/A4pXlTlIZBNiyUcNlPYSqVS9b/vIwckeMCaDjmfdW2Adh8GK04li/63lJ9VAjBdqsykaWEKYh+hp76jIUVxlp+dE4+GqISO+x5iWDLioXh00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DaOVbzC/; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DaOVbzC/" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439b97a8a8cso2476423f8f.1 for ; Fri, 13 Mar 2026 09:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773419967; x=1774024767; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SpEPoHYvhvWkjpmYEpEt8jyUUg5KMMUdOdkwivHgCi4=; b=DaOVbzC/MQfQZvuTtUCqVq+ekt2HGjagyRzoDSez1ksKifQOvRzQStVjVt9jt6Tk1U bdBBx7iFu+Thpx2NA5bGj5w4oU2nSMWaMhs1e+yzddQ40wbImoyTSxT9YNWXqz2nGXF1 fJGv6Wi+pBDosr6/RJ9WsaUHYrTNFxPEZrf0Vyoj3BecjhBXDFdJB6EKonccmftX+p2G ytwkEaYR5PhUrH6LqGqaGr21cdzhSJLjy+PUBsBL3PvHrLTEdYVg/CDKmEWhF5A5u/pI kIRZzLDTXyWvezW8Hb9o6r1Xn5WhFR3iOukr3yBTel4EZjUG7QA2ttSMYBW/QT6+II0/ Tq2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773419967; x=1774024767; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SpEPoHYvhvWkjpmYEpEt8jyUUg5KMMUdOdkwivHgCi4=; b=mJeI5GrR735SoQIrWeQUCTTd9grShbIHRyes8wPzECoQsFXDWkebBjE8CjYxdfqjxC iJkhQ9WVUaTsCnyxYXIvD2hDlBdj0m+S5nn5IgzjnpHBboLQFyQ6J6uguQuA0Y3jaLCt mzGMAJpAaGkS5xWBXnS2TZKRX1Ul4xfmHbwhyoR1rnzrDZh+18ygANEck1mVFiW0DnZM EIyyYgGInmfZSqcoXMLkY7b/2uGGltiH1HnN5ucqvQ39TPh4mC+mLwb/0OhTWs8YxX6W P23qEPbbYqOK1TGMNQcd1Yrj76umqKjmPBgJoo0RgXbBb1/FwPQdKvKyzvLPLviXhTtS bpHg== X-Forwarded-Encrypted: i=1; AJvYcCVckNrsoUvqT9OypefXO0mo2EDNbL5RnciL7+Rh44PL18nY7CCTrYYoKDMZeTqUPdACC+YD3P/jn4sfBPE=@vger.kernel.org X-Gm-Message-State: AOJu0YwXoGORYyGaSJ+vu/Jt3iq/zojaV6LHZhrFAE2PfQ+gISE4gsbl qiSkiG90GbWXgZfzKxv4HXPoUDNJNwfa3Eb56DWwF18VJA9EuDtiefIW X-Gm-Gg: ATEYQzzLSz76sPp9xPIROppuCbTEcysEHCiS5ulnjF7lf3dDesqCWJVxc1fazBqIm0f aX2n3/EW7KLDsC6vBwgDjdz2PFDnQUzG91VhFdakIQvsoH/qbeJUfeGj8MD5o43LRxgVKFg90De JI6dGTDvU9OtY8xyGK9XMGak+mB2hbzEX4GpsuW/l4PiDa6BUGRyR1zjWZ32qM1pZjemiVRALLt BYmGk+uRcVMjjsCgrhHnu/XQueqMW2SuI9vjayzRGXiZGh7EGmVzopKHAblHxL59fP+rPljA8jM kHqpeui/Q8SLrHzdkR4jVW/HEaLMNkXAKhYdz2cCg2V0qPcalLM2ayAWweRVrmVgN8ThFvfNNlL rwElB6z5onO541Zhyz1bQc0cU6ygwIbw85Kthvbc1N0EGHjarE90XN7DOY1BanYNekY32fOooJg C+3FpF1SQzKX5RX52G8H2sP2Ux64B3FY7iYg6j X-Received: by 2002:a05:6000:2283:b0:439:cb79:ab05 with SMTP id ffacd0b85a97d-43a04db5ff4mr7600661f8f.36.1773419967340; Fri, 13 Mar 2026 09:39:27 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe22e9ddsm16346345f8f.37.2026.03.13.09.39.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 09:39:27 -0700 (PDT) Message-ID: <3d27945a-639d-4c3d-969f-2ec23bdd9900@gmail.com> Date: Fri, 13 Mar 2026 18:39:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators To: Conor Dooley Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260312-vcnl4000-regulators-v2-0-2bdebbcbb58a@gmail.com> <20260312-vcnl4000-regulators-v2-1-2bdebbcbb58a@gmail.com> <20260312-slouching-shelf-c8f64433881d@spud> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: <20260312-slouching-shelf-c8f64433881d@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/12/26 7:39 PM, Conor Dooley wrote: > On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote: >> This commit adds regulator properties for vcnl4000 ambient light and >> proximity sensors. > > This we can see. Your commit message should say why. > > Do all devices in the binding have all of these supplies? > If we look at the datasheet for vcnl4040, https://www.vishay.com/docs/84274/vcnl4040.pdf, in figure 11 we can see that there can be 3 supplies: sensor supply Vdd (vdd), I2C supply for the bus Vpull_up (vddio) and IR LED anode Vdd_led (vled). The other datasheets refer to three supplies as well - one for the sensor, one for anode and one for the bus: https://www.vishay.com/docs/83372/vcnl4000.pdf https://www.vishay.com/docs/84138/designingvcnl4010.pdf https://www.vishay.com/docs/84327/designingvcnl4200.pdf >> >> Signed-off-by: Erikas Bitovtas >> --- >> Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> index 2ba4d5de4ec4..a1b4c02db246 100644 >> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> @@ -33,6 +33,10 @@ properties: >> interrupts: >> maxItems: 1 >> >> + vdd-supply: true >> + vddio-supply: true >> + vled-supply: true >> + >> reg: >> maxItems: 1 >> >> @@ -54,6 +58,9 @@ examples: >> compatible = "vishay,vcnl4200"; >> reg = <0x51>; >> proximity-near-level = <220>; >> + vdd-supply = <®_vdd>; >> + vddio-supply = <®_vddio>; >> + vled-supply = <®_vled>; >> }; >> }; >> ... >> >> -- >> 2.53.0 >>