From: Guenter Roeck <linux@roeck-us.net>
To: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: qcom-wdt: Document IPQ5210 watchdog
Date: Wed, 27 May 2026 21:00:16 -0700 [thread overview]
Message-ID: <3d285a40-b371-4e61-9648-44c2fbdcb3e5@roeck-us.net> (raw)
In-Reply-To: <51fb3abd-998c-45a8-a058-ab9185d6fd7f@oss.qualcomm.com>
On Tue, May 26, 2026 at 09:40:53AM +0530, Kathiravan Thirumoorthy wrote:
>
> On 5/11/2026 4:19 PM, Kathiravan Thirumoorthy wrote:
> > Document the watchdog device found on the Qualcomm IPQ5210 SoC.
> >
> > Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> > ---
> > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> > index 9f861045b71e..21f6f7db7f96 100644
> > --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> > @@ -20,6 +20,7 @@ properties:
> > - qcom,apss-wdt-glymur
> > - qcom,kpss-wdt-ipq4019
> > - qcom,apss-wdt-ipq5018
> > + - qcom,apss-wdt-ipq5210
> > - qcom,apss-wdt-ipq5332
> > - qcom,apss-wdt-ipq5424
> > - qcom,apss-wdt-ipq9574
>
>
> Guenter,
>
> Could you please pick up this change? The watchdog device node addition
> merged in linux-next[1] is triggering the DT binding error below.
>
Not yet. It may sound trivial, but I will need a Reviewed-by: tag from
a devicetree maintainer. Patchwork does not show one, and I don't recall
seeing one either.
Guenter
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> DTC [C] arch/arm64/boot/dts/qcom/ipq5210-rdp504.dtb
> /local/mnt/workspace/kathirav/upstream/linux-next/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dtb:
> watchdog@b017000 (qcom,apss-wdt-ipq5210): compatible: 'oneOf' conditional
> failed, one must be fixed:
> ['qcom,apss-wdt-ipq5210', 'qcom,kpss-wdt'] is too long
> ['qcom,apss-wdt-ipq5210', 'qcom,kpss-wdt'] is too short
> 'qcom,apss-wdt-ipq5210' is not one of ['qcom,apss-wdt-glymur',
> 'qcom,apss-wdt-hawi', 'qcom,kpss-wdt-ipq4019', 'qcom,apss-wdt-ipq5018',
> 'qcom,apss-wdt-ipq5332', 'qcom,apss-wdt-ipq5424', 'qcom,apss-wdt-ipq9574',
> 'qcom,apss-wdt-ipq9650', 'qcom,apss-wdt-kaanapali', 'qcom,apss-wdt-msm8226',
> 'qcom,apss-wdt-msm8974', 'qcom,apss-wdt-msm8994', 'qcom,apss-wdt-nord',
> 'qcom,apss-wdt-qcm2290', 'qcom,apss-wdt-qcs404', 'qcom,apss-wdt-qcs615',
> 'qcom,apss-wdt-qcs8300', 'qcom,apss-wdt-sa8255p', 'qcom,apss-wdt-sa8775p',
> 'qcom,apss-wdt-sc7180', 'qcom,apss-wdt-sc7280', 'qcom,apss-wdt-sc8180x',
> 'qcom,apss-wdt-sc8280xp', 'qcom,apss-wdt-sdm845', 'qcom,apss-wdt-sdx55',
> 'qcom,apss-wdt-sdx65', 'qcom,apss-wdt-shikra', 'qcom,apss-wdt-sm6115',
> 'qcom,apss-wdt-sm6350', 'qcom,apss-wdt-sm8150', 'qcom,apss-wdt-sm8250',
> 'qcom,apss-wdt-x1e80100']
> 'qcom,kpss-wdt' was expected
> 'qcom,scss-timer' was expected
> 'qcom,apss-wdt-ipq5210' is not one of ['qcom,kpss-wdt-apq8064',
> 'qcom,kpss-wdt-ipq8064', 'qcom,kpss-wdt-mdm9615', 'qcom,kpss-wdt-msm8960']
> 'qcom,msm-timer' was expected
> 'qcom,kpss-timer' was expected
> from schema $id:
> http://devicetree.org/schemas/watchdog/qcom-wdt.yaml
> arch/arm64/boot/dts/qcom/ipq5210-rdp504.dtb: /soc@0/watchdog@b017000: failed
> to match any schema with compatible: ['qcom,apss-wdt-ipq5210',
> 'qcom,kpss-wdt']
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm64/boot/dts/qcom/ipq5210.dtsi?id=7a473107f9785700a5c57cee69f60c19a9703f95
>
> >
> > ---
> > base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83
> > change-id: 20260511-ipq5210_wdt_binding-9f77d959a28b
> >
> > Best regards,
> > --
> > Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> >
next prev parent reply other threads:[~2026-05-28 4:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 10:49 Kathiravan Thirumoorthy
2026-05-26 4:10 ` Kathiravan Thirumoorthy
2026-05-28 4:00 ` Guenter Roeck [this message]
2026-06-02 22:34 ` Rob Herring
2026-06-08 18:56 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d285a40-b371-4e61-9648-44c2fbdcb3e5@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®