mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <corbet@lwn.net>, <skhan@linuxfoundation.org>,
	<rdunlap@infradead.org>, <clrkwllms@kernel.org>,
	<rostedt@goodmis.org>, <rppt@kernel.org>, <arnd@arndb.de>,
	<bp@alien8.de>, <kmehltretter@gmail.com>,
	<dapeng1.mi@linux.intel.com>, <elver@google.com>,
	<enelsonmoore@gmail.com>, <jlayton@kernel.org>,
	<quchaosheng000406@163.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-rt-devel@lists.linux.dev>
Subject: Re: [PATCH 2/2] docs: sched-preemption: Fix the list of runtime-selectable models
Date: Tue, 3 Nov 2026 10:15:54 +0800	[thread overview]
Message-ID: <3d2968f2-5171-4558-92a3-41cab745d282@huawei.com> (raw)
In-Reply-To: <20261102133424.rJTJIkFX@linutronix.de>



在 2026/11/2 21:34, Sebastian Andrzej Siewior 写道:
> On 2026-10-28 10:43:33 [+0800], Jinjie Ruan wrote:
>> --- a/Documentation/scheduler/sched-preemption.rst
>> +++ b/Documentation/scheduler/sched-preemption.rst
>> @@ -20,9 +20,6 @@ change.
>>  The models selectable at runtime are:
>>  
>>  	=========	====================================================
>> -	none		No preemption of kernel code other than at explicit
>> -			``cond_resched()`` / blocking points.
>> -	voluntary	As ``none``, plus ``might_sleep()`` sites.
>>  	full		Any section that is not explicitly preempt disabled
>>  			may be preempted at any time.
>>  	lazy		As ``full``, except that the scheduling request is
> 
> This is fine.
> 
>> @@ -31,10 +28,12 @@ The models selectable at runtime are:
>>  			apply to real-time tasks.
>>  	=========	====================================================
>>  
>> -Not every model is available on every kernel.  An architecture that provides
>> -lazy-preempt support offers only ``full`` and ``lazy``, and ``none`` and
>> -``voluntary`` are rejected there.  A PREEMPT_RT kernel always offers ``full``,
>> -and ``lazy`` as well if the architecture provides it.
>> +CONFIG_PREEMPT_DYNAMIC depends on CONFIG_ARCH_HAS_PREEMPT_LAZY, so ``none``
>> +and ``voluntary`` are never selectable at runtime; passing either is
>> +rejected with "Dynamic Preempt: unsupported mode".  The two models are only
>> +left as build-time choices on architectures without lazy-preempt support.
>> +A PREEMPT_RT kernel always offers ``full``, and ``lazy`` as well if the
>> +architecture provides it.
> 
> What about:
>  Not every model is available on every kernel.  An architecture that provides
>  preemption support supports ``full``. If additionally lazy-preempt is
>  supported then the choice ``lazy`` becomes available. An architecture
>  without preemption support can not enable CONFIG_PREEMPT_DYNAMIC. On

Hi Sebastian,

There seems to be an issue with this sentence: PREEMPT_DYNAMIC depends
on ARCH_HAS_PREEMPT_LAZY, not “preemption support.”

What about:

Not every model is available on every kernel.  A kernel built with
CONFIG_PREEMPT_DYNAMIC offers only ``full`` and ``lazy``; ``none`` and
``voluntary`` can only be chosen at build time, on architectures where
they are available.  A PREEMPT_RT kernel always offers ``full``, and
``lazy`` as well if the architecture provides it.


>  such an architecture the preemption model can only be selected at
>  compile time. 
> 
> Sebastian

-- 
Best regards,
Jinjie


      reply	other threads:[~2026-11-03  2:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28  2:43 [PATCH 0/2] docs: Remove the unsupported preempt= modes Jinjie Ruan
2026-10-28  2:43 ` [PATCH 1/2] docs: kernel-parameters: Drop " Jinjie Ruan
2026-10-28 15:40   ` Daniel Pereira
2026-11-02 13:34   ` Sebastian Andrzej Siewior
2026-10-28  2:43 ` [PATCH 2/2] docs: sched-preemption: Fix the list of runtime-selectable models Jinjie Ruan
2026-10-28 15:43   ` Daniel Pereira
2026-11-02 13:34   ` Sebastian Andrzej Siewior
2026-11-03  2:15     ` Jinjie Ruan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d2968f2-5171-4558-92a3-41cab745d282@huawei.com \
    --to=ruanjinjie@huawei.com \
    --cc=arnd@arndb.de \
    --cc=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=clrkwllms@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=elver@google.com \
    --cc=enelsonmoore@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=kmehltretter@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=quchaosheng000406@163.com \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®