From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D24E621B9DA for ; Sun, 30 Nov 2025 22:20:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764541210; cv=none; b=oex4rbVM9cNu/gB+M5v59JQwT0C91BZBRw5NkyayhMSXSxLudzYYxXGET12dCD27NQePtxSvyz7USa7bdeh8HlMssdMiRJKbz49rD0eeW3qNpQXKhKs9wra1kmvn3UI6G7p4FIcfQ3QqXILuBSh9llw7p4R03nzcfIGuUjTz4IU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764541210; c=relaxed/simple; bh=jvH0nM1Cqz/PTqIMLIAYBQwAEoV3Q0avK1+A/z2ALk4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jbEiUpWPdIA3mvnjLYqH4ust5qbnd+mo6VRuHEURZbt0P45uE3/YfU0fKETGwGVKe+cmWGxvNtOo5sKXt11eFAVm9qFMEcGYG9+ElDb7bz7SLk3JUDCS22NUiKs8w0ekBpGNWeyQDErso/1Ub8YcV8GrlSdHFQiCgiRpEIc9/kE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47795f6f5c0so18907205e9.1 for ; Sun, 30 Nov 2025 14:20:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764541206; x=1765146006; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MK8iOyT68uTwYDM4nUUD7HACjnrHxqKZjkHBRY78i1g=; b=Fa3Ou7gISgs8Y8dbSX+Y6k4fPR1tL0nODy9viTxc+N8SqJsss5OhA7hF5NW+Qt+Djp tmBIUVvDGg/akz/tUSrLjFOuPHJiH5A1jOETiWCfJv3RQC0tV25LoRsODSPwnrBPVRxe kuKB0SiX2Cpxzk/gXv+j3Axm7qHfThSFm240dNjpEvtExa6KR0XA8bzXM3UZ5l09BkBk FyDRBB1Kx+V74uw51SVV3t7YvFaZbEINwMFxteAJpINgWYznSvhIWLThDQrv+F6A1LWe C02KuPd01RqbpNfzzNcwkCLyAx9wIR3Y/3ajc3vYuh30wC/RG5GRCOal+aoxm8YFEaZm fD5Q== X-Forwarded-Encrypted: i=1; AJvYcCXMEeWR6He2nKvOv+KFFmM51JsZ0Qgomq3jRr+M0PUd/YsxVCEikFocBLgYVTI8Hm+Uykqj4224Bo4gMhU=@vger.kernel.org X-Gm-Message-State: AOJu0YyNits/v17V7tIzEIZNj6YGrAtzFllurCilG58U1RtW8zMv1f4r f0b3L/qbGkfdhsMqvSVVLhpHJes+OTpMPwe85lYw+CVmWApx/957RDNq X-Gm-Gg: ASbGncvRgJvyXubFWQBJkK+Ta+fXsoT+1y8XPGoxWiXfXtGhFFqn10cBg3gaSvC2Ds2 vvwBRLNa7p9qjaJ6W70aLpN2cESBFEEnkhNCEcTZh2Or03g4wzJSWgJS4/4uo81+DS77jCfaTfP +RI5NGD6Cgsk5/GXL0px/j8Ki9ZIfQNms2dHzEdnfzhankRFs3fCgHFfeeHRXaQOCeN44GL3IDb L6cBC70S5UV6BMAxEwvAZZ6/jTLs7Gt0/pvzsVq4zBdda/SWDjDt9yntykU5NfoU12hNIKrDk+s noJckhdETbzDARKbmfl8j2Jz2aXVUTRZjgJOkUCzAuX+v1hcHOOr9T48XIvajL2cRg8ttmomMja 1g0dRRjtpnY1QPMaV3SYYvmw9GRjPDfBeuwd4iUT7Y7Jj1nYtrpv7V16rUMiNnJ4Ex9ywdg9Ppt zD+s9nEonUFOU4+vPVUX5kgmOUi8o8A2gbOo6eq6Bw X-Google-Smtp-Source: AGHT+IF5uQOTcJv09f95vlUdzQFWw4u3uwwRi1AYDrMwsvowx8yGwq1f6KIXa1PJBgPPJypVSpOrrQ== X-Received: by 2002:a05:600c:1f8f:b0:477:a0dd:b2af with SMTP id 5b1f17b1804b1-477c01ea502mr321465525e9.33.1764541206088; Sun, 30 Nov 2025 14:20:06 -0800 (PST) Received: from [10.100.102.74] (89-138-71-2.bb.netvision.net.il. [89.138.71.2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479111565a1sm201200255e9.5.2025.11.30.14.20.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Nov 2025 14:20:05 -0800 (PST) Message-ID: <3d2cb8e7-aecc-4ae4-a114-04bd59741e7c@grimberg.me> Date: Mon, 1 Dec 2025 00:20:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme: nvme_identify_ns_descs: prevent oob To: Eugene Korenevsky , Christoph Hellwig Cc: Keith Busch , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251127144916.GA9423@lst.de> Content-Language: en-US From: Sagi Grimberg In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/11/2025 21:57, Eugene Korenevsky wrote: > On Thu, Nov 27, 2025 at 03:49:16PM +0100, Christoph Hellwig wrote: > >> I think we'll need a somewhat more complex check that at there >> is at least enough space for the len member. But I prefer that >> style over a table lookup and magic name pasting macros. > Okay, simplified the patch. See v2. Did you send it?