From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 560F9C433E0 for ; Wed, 17 Jun 2020 16:14:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30FD62080D for ; Wed, 17 Jun 2020 16:14:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="rzAm3ReT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbgFQQOZ (ORCPT ); Wed, 17 Jun 2020 12:14:25 -0400 Received: from mout.web.de ([212.227.15.4]:36499 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726597AbgFQQOZ (ORCPT ); Wed, 17 Jun 2020 12:14:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1592410449; bh=L7NPJqF6WRIs5fDwphZDoi0ha33NtLh00PGn9Tln6uw=; h=X-UI-Sender-Class:Cc:Subject:From:To:Date; b=rzAm3ReTB7xW84XXFZjVlk6orUzEsOfEIafImpvArAgnv+Sd8yuNX1m99W4NurWvZ WeNZ/eAgqnh1EkaQoLPxQxoElJDT4YhbgmCI2/GOBboFUNjRzeqKKsKP1EXiGL99Wd 4cMaogv7Tl/iBJTNLg9t0Vmsy5qEUWnYb60lBJR4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.133.115.66]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N0qqv-1j0esW1xjB-00wlu8; Wed, 17 Jun 2020 18:14:09 +0200 Cc: "Gustavo A. R. Silva" , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: [PATCH] coccinelle: misc: add array_size_dup script to detect missed overflow checks From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= To: Denis Efremov , Julia Lawall , Coccinelle Message-ID: <3d375680-cf02-5e2d-fcf0-69b3bdcbf748@web.de> Date: Wed, 17 Jun 2020 18:14:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ZWtQepdeNIFRFkkAOBrgKMXcCzYvDhWc/KNRvcjJjTFR5a39IEU y9bPS0wnH5WCew+ACOlBKaPqlGOyVJCVU2m6cNTtkitTAZyTz+J8y5liIR4PRzq1tjxh7hu AlBaebq3mPjCyp3OvYmiFdfxi3VL25YQU+PKfxGal+gCk8HEycJM41JJgtVxws+2s4ZAwwZ g6TviPTlWfXg3xy33/jGQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Lhx4k/MhV0U=:rmtZNedd+LkTRKx6Cicttr RkqwG9R8kuQdAuPbhrgjgIyo2vKgUCPEaJ7/2wu4h4/HU0OCxHagcSkSStN9MQlUcpaL/Ito4 b/6qIZeyxTuu7gKQemszVgf4uveQWPS/f0EE4CljMkmveqH0i+B9fh38sILAo6dg0PtmMFybL zqXPT7QUrmE+dFi2YgyHWTrVgDzQ9AO7zVQ5jnDotUV28QRUc2SqBt8s5JtsACJPIFJkfgU6q jaxRycaw+Hj/rGAKSFDiSS/7sJ/9C7eVmJ9Xv3Mm84etVobqTJJpPrapdN1rZPxgY+Gp9eudW R+B8VQqzXF2YF0fYdfgFFadbUp1b8HB7I9AikBJ+MKpAoyaC7MBpZDh/KYL5b670bHZGxYsAw fgdlzYeNWurREwgwxwhWb9wQJXgXqBqg80j7d2LhbFcS28DZPVdpVCyXlRJvq28Za+NpFYKwX YYP6Lfxi9IjAl6NwAhXlIwKjri7HjALeRt8PNDX2hSzChj4Ri2jPpXFyWur1/qOGI31qYXmT8 Uu8aYhMkLQovakmYmBfwgW+yqFDt/y6o1AaQd9k2mvTjpVWYIbsJZpb/mFRjf5TEiPA/3xMV8 qw4qIi+LJb42u3y3a14H3RFdusQpid6QfUtQHIzksp9oG9zYUqJYGEaD3z/eLTCeDeO1x37yd IBOR2Rioj/VM6BJSubRNUSx6+41yOs1Kxyh7XC0+pbsqTIQWZ5KpKr+58lUhdX9rwT0Lbp94s 0tgeZhkWVrkMOqSn+8/hrb3conl6jxBH+6L8xQi7gtWIM2/U8YAs+4O+gcpxngSU/el4pqdT3 7RQ67iWvlinzV9t+YwgVFVKsXMI0oXHJhMLRkvYfCP33udURnG6659QsIF8BoJ2c9Rxc1zxBM Mqsvx73TNqwjwRBkqbA9p/tUxXIjZ8IZLsgu5cxmpGgOFvH5ICBe/Paps97uxBhy/YL4Zs9px SoNclFit7SktxXCV9iJHWueX2ohwSxp7gKLPbn2XRCwKw+2BoUarznXmNoG35R8GlqOOq5wyL gxI6XjAZyJIn7GoYPwi2+FlmnlmaRQ9Yg4Zu7nGwnxoQ42yWEzKRwNjd43bMdsVU6N9XIfpQv DJbyvaJBNnfny/o3kLuL84WkTA5BgXQB6+CymvIwrgyjRQutf2DFW4dKrgs5HP4sSQZlTfVHe CyIEqET9rA6FXdpxqyfSyPrgOaPXWBf6h5YIgJCvAQu1hMhacvXf+H1xf1JJXkC9CE6Ry8D1p 7Jyo5fESOL7wOcbnt Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > ( > * size =3D E1 * E2;@p > | > * size =3D E1 * E2 * E3;@p > | > * size =3D E1 * E2 + E3;@p > ) I suggest to reconsider also the order of elements for such a SmPL disjunc= tion. Can a computation like =E2=80=9CE2 * E3=E2=80=9D also be matched by the ex= pression metavariable =E2=80=9CE2=E2=80=9D alone? Regards, Markus