From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67DAFC433B4 for ; Wed, 19 May 2021 15:56:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49DD960FE6 for ; Wed, 19 May 2021 15:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355018AbhESP6R (ORCPT ); Wed, 19 May 2021 11:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346960AbhESP6Q (ORCPT ); Wed, 19 May 2021 11:58:16 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 226A9C06175F for ; Wed, 19 May 2021 08:56:56 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id k19so10200816pfu.5 for ; Wed, 19 May 2021 08:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Ewak3FTzWtebTNxoU2UtRKv4KOXoJSP/mAhC0k4hkGM=; b=hkd5bEswK+JxcSDlikju+ubqHI1xgQN8FMkYsn7Vos/ojbGpOVlnVRo46fJcopr+2/ dZoWgvHogx/isb9Pbvj5zLSOPJqa0tZErbp9pINkN634jI7lLNYngeljfYeCHA1cZ5f1 n5i2TpmPC7pERnWWD/VGE6/UcA3SGhtph8kshiQz9fVQFfna3U2Ogd/y99NyOJA6FiDe H9PF1MjWBY6NcbJNa5GV3defOCr2B7Fb4xWYSq4fo5uALRhXLPsedBLvz8vAmPjeaZRP 87SAZk9cQqNYZJQd2B5ND5UOS+FRU32J0ZMQ3A0uuUcfKSkWDrEjTBNMrxFHb7N+CtoN hKaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Ewak3FTzWtebTNxoU2UtRKv4KOXoJSP/mAhC0k4hkGM=; b=DiauEHwWRLHvQoF+TK2tCDgCkcu4FUIp1vi8J5YhTjSjEeBsYcF5koEJ92ppgTEg27 LLOR0leTTEBhR3iWOYfOhtB7yWOsDATOF0iDM2HCtBZDZBwMlVVGHncbskLQSp3VQ8VZ GfQg8yicVnMYOlzVz1mmsFZEFQHUoL9qGpUlxok3sGZA0F3YARs9+N6pVYEgyvOhuDdT RlR0fgLFefrW+UkYFMY4LwVRAjZkNcS4dtFtwrDg9NZpRLOPqBZUvXfAH8+IQTASDSQM 4AWczLFn66+WR9rKA9UXTkmQxVuyqKfHjNI9VGvlK1snzXY0zpzSSZb0zGbJG7A2ZPP4 qw5A== X-Gm-Message-State: AOAM532Ph0/Ii59pUdNMguq96oRGFDd8Ptz2Ycng3aL7TUT7sUrF6AT3 Ww+87PJNzXfNrfSQa3Ha4Zs= X-Google-Smtp-Source: ABdhPJw9825Sqsf9H9wHD5H3DXvyJJo/Vpqnzgh5AFQb9O1AmveZhjrk2GjlrBvHahxN3M2cunyddg== X-Received: by 2002:aa7:97ad:0:b029:2e0:26a8:8da5 with SMTP id d13-20020aa797ad0000b02902e026a88da5mr2154968pfq.37.1621439815488; Wed, 19 May 2021 08:56:55 -0700 (PDT) Received: from [192.168.1.2] ([103.196.78.23]) by smtp.gmail.com with ESMTPSA id u21sm14568714pfm.89.2021.05.19.08.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 08:56:54 -0700 (PDT) Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with 'const' keyword To: Greg Kroah-Hartman Cc: =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: <20210519081958.7223-1-hridayhegde1999@gmail.com> <0ddb894f-f66f-f31b-ef8a-0646e0a99b9f@gmail.com> <08cf8110-cf84-8784-c919-eba27474b796@gmail.com> From: Hriday Hegde Message-ID: <3d382048-17d5-e933-7c5e-1af7de218a16@gmail.com> Date: Wed, 19 May 2021 21:26:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-05-2021 20:25, Greg Kroah-Hartman wrote: > On Wed, May 19, 2021 at 08:06:14PM +0530, Hriday Hegde wrote: >> On 19-05-2021 15:20, Greg Kroah-Hartman wrote: >>> A: http://en.wikipedia.org/wiki/Top_post >>> Q: Were do I find info about this thing called top-posting? >>> A: Because it messes up the order in which people normally read text. >>> Q: Why is top-posting such a bad thing? >>> A: Top-posting. >>> Q: What is the most annoying thing in e-mail? >>> >>> http://daringfireball.net/2007/07/on_top >>> >>> On Wed, May 19, 2021 at 03:00:08PM +0530, Hriday Hegde wrote: >>>> I am not really sure how to do that and how to reflect it in the patch i followed what was taught in the Beginners course and it does not mention building. I know i need to test it out but is running 'patch -p1 < x.patch what i need to do? >>> That does not build the code you changed, right? >>> >>> I'm sure whatever course you took, it did reference the fact that you >>> need to ensure that your change actually works properly by the very >>> least being able to be compiled correctly. Please go over those >>> instructions again. >>> >>> good luck! >>> >>> greg k-h >> I am using the A Beginner's Guide to Linux Kernel Development (LFD103) by the linux foundation for this but i cant find any commands to as to build and test , the only way i tried compiling is with a custom Makefile and it didn't work, i've got a few errors so the const keyword might not work here since the variable is being written to. >> >> > That is correct, when compiling (i.e. building), the compiler shows that > this is not a correct change. > > thanks, > > greg k-h Oh ok will work with something else. Thanks.