From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034361AbdAERoR (ORCPT ); Thu, 5 Jan 2017 12:44:17 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35424 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966813AbdAERoJ (ORCPT ); Thu, 5 Jan 2017 12:44:09 -0500 Subject: Re: [RFC 1/1] Changes to support the driver for platform device registration To: Raviteja Garimella , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Felipe Balbi References: <1483604597-26160-1-git-send-email-raviteja.garimella@broadcom.com> <1483604597-26160-2-git-send-email-raviteja.garimella@broadcom.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-usb@vger.kernel.org From: Florian Fainelli Message-ID: <3d3e9fce-faae-3ff0-c42c-20f4bced663a@gmail.com> Date: Thu, 5 Jan 2017 09:43:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1483604597-26160-2-git-send-email-raviteja.garimella@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2017 12:23 AM, Raviteja Garimella wrote: > -- Add OF based platform device registration > -- Modify debug prints to be compatible with both pci and platform devices > -- Add members to 'struct udc' for extcon and phy support > -- Add checks to not process repeated calls to udc connect and > disconnect routines > -- Kconfig changes What you are doing in this patch is all well and good, but since you are listing these changes, that means we should see 4/5 patches submitted to this driver each one doing what you have as a bullet point. Since you are adding Device Tree probing support to the driver, you also need to create a proper binding document which describes the properties and nodes. Thank you -- Florian